[release-0.17] Backport #1092#1105
Merged
knative-prow-robot merged 4 commits intoknative:release-0.17from Nov 11, 2020
Merged
Conversation
* Add channel sink prefix * Add unit and e2e tests * Add CHANGELOG * Fix e2e tests
knative-prow-robot
added
approved
navidshaikh
added
backport/pr
Fixes unit tests by adding Channel GVK to fake dynamic client
knative-prow-robot
added
approved
Contributor
|
/lgtm |
Contributor
Author
|
/retest |
1 similar comment
Contributor
|
/retest |
knative-prow-robot
added
lgtm
Contributor
Author
|
/retest |
navidshaikh
force-pushed
the
pr/rel-0.17-backports
branch
2 times, most recently
from
21a974f to
228a326
Compare
maximilien
approved these changes
Nov 10, 2020
Contributor
maximilien
left a comment
maximilien
left a comment
There was a problem hiding this comment.
/test pull-knative-client-integration-tests
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
navidshaikh
force-pushed
the
pr/rel-0.17-backports
branch
from
228a326 to
69d75b6
Compare
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: