Skip to content

[release-0.18] Backport of #1117#1132

Merged
knative-prow-robot merged 2 commits intoknative:release-0.18from
navidshaikh:rel/v0.18.3
Nov 24, 2020
Merged

[release-0.18] Backport of #1117#1132
knative-prow-robot merged 2 commits intoknative:release-0.18from
navidshaikh:rel/v0.18.3

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

Backport PR for release-v0.18.3 with

…1117)

* Embed the namespace in request body while creating channels

 since on the eventing side, defaulting for channel isnt picking
 the namespace from the context (see knative/eventing#4514)

 workaround for knative#1100
 this changeset should be reverted when eventing#4514 is resolved

* Add CHANGELOG
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 23, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 23, 2020
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/channel/describe.go 79.5% 76.9% -2.6

Copy link
Copy Markdown
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 6bcfca5 into knative:release-0.18 Nov 24, 2020
@navidshaikh navidshaikh added the backport/pr A backport PR which is target to a release branch. label Nov 24, 2020
dsimansk pushed a commit to dsimansk/client that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport/pr A backport PR which is target to a release branch. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants