Embed the namespace in request body while creating channels#1117
Merged
knative-prow-robot merged 2 commits intoknative:masterfrom Nov 12, 2020
Merged
Conversation
since on the eventing side, defaulting for channel isnt picking the namespace from the context (see knative/eventing#4514) workaround for knative#1100 this changeset should be reverted when eventing#4514 is resolved
knative-prow-robot
added
approved
rhuss
reviewed
Nov 12, 2020
Contributor
rhuss
left a comment
rhuss
left a comment
There was a problem hiding this comment.
Looks good to me, but please add a Changelog entry, too. I think this bug is worth mentioning in there.
knative-prow-robot
added
size/M
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
navidshaikh
added
the
backport/candidate
navidshaikh
added a commit
to navidshaikh/client
that referenced
this pull request
Nov 23, 2020
…1117) * Embed the namespace in request body while creating channels since on the eventing side, defaulting for channel isnt picking the namespace from the context (see knative/eventing#4514) workaround for knative#1100 this changeset should be reverted when eventing#4514 is resolved * Add CHANGELOG
navidshaikh
added a commit
to navidshaikh/client
that referenced
this pull request
Nov 24, 2020
…1117) * Embed the namespace in request body while creating channels since on the eventing side, defaulting for channel isnt picking the namespace from the context (see knative/eventing#4514) workaround for knative#1100 this changeset should be reverted when eventing#4514 is resolved * Add CHANGELOG
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 24, 2020
* Embed the namespace in request body while creating channels (#1117) * Embed the namespace in request body while creating channels since on the eventing side, defaulting for channel isnt picking the namespace from the context (see knative/eventing#4514) workaround for #1100 this changeset should be reverted when eventing#4514 is resolved * Add CHANGELOG * Update changelog for v0.18.3
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 24, 2020
* Embed the namespace in request body while creating channels (#1117) * Embed the namespace in request body while creating channels since on the eventing side, defaulting for channel isnt picking the namespace from the context (see knative/eventing#4514) workaround for #1100 this changeset should be reverted when eventing#4514 is resolved * Add CHANGELOG * Update CHANGELOG for v0.17.4
navidshaikh
added a commit
to navidshaikh/client
that referenced
this pull request
Nov 24, 2020
…1117) * Embed the namespace in request body while creating channels since on the eventing side, defaulting for channel isnt picking the namespace from the context (see knative/eventing#4514) workaround for knative#1100 this changeset should be reverted when eventing#4514 is resolved * Add CHANGELOG
navidshaikh
added
backported-to/0.17
and removed
backport/candidate
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 25, 2020
* Embed the namespace in request body while creating channels (#1117) * Embed the namespace in request body while creating channels since on the eventing side, defaulting for channel isnt picking the namespace from the context (see knative/eventing#4514) workaround for #1100 this changeset should be reverted when eventing#4514 is resolved * Add CHANGELOG * Update CHANGELOG for v0.19.1 * Cross-compile the kn binary for linux/s390x (#1083) * Update CHANGELOG for v0.19.1 * Fix date in changelog * Fix race conditions when creating watches (#1113) * Fix a race condition between creating a watch and initiating the action that emits the event it is watching for * update changelog * add PR ID to changelog entry * Fix merge in Changelog * Fix table format in Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Embed the namespace in request body while creating channels
since on the eventing side, defaulting for channel isnt picking
the namespace from the context (see knative/eventing#4514)
workaround for #1100
this changeset should be reverted when eventing#4514 is resolved
Changes
Reference
workaround for #1100 and knative/eventing#4514