Cross-compile the kn binary for linux/s390x by BbolroC · Pull Request #1083 · knative/client

BbolroC · 2020-10-30T15:52:17Z

Description

As part of the work to support the knative for the IBM Z system (s390x architecture), this PR is to make the kn-linux-s390x binary available in the release.

Changes

Add an additional go build command with GOOS=linux GOARCH=s390x in hack/build.sh and hack/release.sh, respectively.

Reference

None

knative-prow-robot · 2020-10-30T15:52:30Z

Welcome @BbolroC! It looks like this is your first PR to knative/client 🎉

knative-prow-robot · 2020-10-30T15:52:31Z

Hi @BbolroC. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhuss · 2020-10-30T18:25:37Z

/ok-to-test

rhuss

Looks good to me, thanks for the PR ! (a minor suggestion added).

Technically that's ok (and affair that's the second request for adding s390), so I tend to add this platform, too. I wonder whether we then should go all in and also add other popular platforms like armv7 or arm64.

Also, we then should push multiarch OCI image for our binary.

Wdyt, @maximilien @navidshaikh and others ? Let's discuss this on the next WG call how wide we want to extend our arch support.

maximilien

/ok-to-test

maximilien

LGTM

maximilien · 2020-11-11T22:14:09Z

Looks like you need to rebase @BbolroC file: hack/release.sh

BbolroC · 2020-11-11T22:51:02Z

Looks like you need to rebase @BbolroC file: hack/release.sh

Thanks for the notice. The rebase is done.

navidshaikh

/lgtm
/approve
could've made to v0.19 release , but we can consider this for patch release as well?
/hold for @rhuss

knative-prow-robot · 2020-11-12T07:03:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BbolroC, maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhuss · 2020-11-24T08:30:30Z

could've made to v0.19 release , but we can consider this for patch release as well?

+1 one for backporting this to 0.18 and 0.19

/unhold

BbolroC · 2020-11-24T11:13:09Z

/retest

navidshaikh · 2020-11-24T18:05:00Z

/test pull-knative-client-integration-tests

Co-authored-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>

* Embed the namespace in request body while creating channels (#1117) * Embed the namespace in request body while creating channels since on the eventing side, defaulting for channel isnt picking the namespace from the context (see knative/eventing#4514) workaround for #1100 this changeset should be reverted when eventing#4514 is resolved * Add CHANGELOG * Update CHANGELOG for v0.19.1 * Cross-compile the kn binary for linux/s390x (#1083) * Update CHANGELOG for v0.19.1 * Fix date in changelog * Fix race conditions when creating watches (#1113) * Fix a race condition between creating a watch and initiating the action that emits the event it is watching for * update changelog * add PR ID to changelog entry * Fix merge in Changelog * Fix table format in Changelog

* Cross-compile the kn binary for linux/s390x (#1083) * Update CHANGELOG for kn v0.18.4 * Fix race conditions when creating watches (#1113) * Fix a race condition between creating a watch and initiating the action that emits the event it is watching for * update changelog * add PR ID to changelog entry * Fix merge in Changelog * Fix table format in Changelog

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 30, 2020

knative-prow-robot requested review from navidshaikh and sixolet October 30, 2020 15:52

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2020

knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2020

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2020

rhuss reviewed Oct 30, 2020

View reviewed changes

Comment thread hack/build.sh

Comment thread hack/release.sh

maximilien approved these changes Oct 30, 2020

View reviewed changes

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020

BbolroC changed the title ~~Cross-compile the kn binary for linux/s390x~~ WIP: Cross-compile the kn binary for linux/s390x Oct 30, 2020

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2020

BbolroC changed the title ~~WIP: Cross-compile the kn binary for linux/s390x~~ Cross-compile the kn binary for linux/s390x Nov 11, 2020

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2020

maximilien approved these changes Nov 11, 2020

View reviewed changes

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2020

Cross-compile the kn binary for linux/s390x

e7e1423

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2020

navidshaikh approved these changes Nov 12, 2020

View reviewed changes

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2020

knative-prow-robot assigned navidshaikh Nov 12, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2020

navidshaikh added this to the v0.20.0 milestone Nov 24, 2020

navidshaikh added the backport/candidate Consider this PR to be backported to the release branch label Nov 24, 2020

knative-prow-robot merged commit 724b0bd into knative:master Nov 24, 2020

navidshaikh pushed a commit to navidshaikh/client that referenced this pull request Nov 25, 2020

Cross-compile the kn binary for linux/s390x (knative#1083)

29adf96

Co-authored-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>

navidshaikh mentioned this pull request Nov 25, 2020

[release-0.19] Backport #1117 #1083 #1113 #1135

Merged

navidshaikh pushed a commit to navidshaikh/client that referenced this pull request Nov 25, 2020

Cross-compile the kn binary for linux/s390x (knative#1083)

44d9f14

Co-authored-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>

navidshaikh mentioned this pull request Nov 25, 2020

[release-0.18] Backport #1083 #1113 #1138

Merged

navidshaikh added a commit to navidshaikh/client that referenced this pull request Nov 25, 2020

Cross-compile the kn binary for linux/s390x (knative#1083)

94e77c3

navidshaikh added a commit to navidshaikh/client that referenced this pull request Nov 25, 2020

Cross-compile the kn binary for linux/s390x (knative#1083)

1bdd7af

navidshaikh added backported-to/0.18 and removed backport/candidate Consider this PR to be backported to the release branch labels Nov 26, 2020

yselkowitz mentioned this pull request Nov 27, 2020

Build and release binaries for linux/ppc64le #1153

Merged

Conversation

BbolroC commented Oct 30, 2020

Description

Changes

Reference

Uh oh!

knative-prow-robot commented Oct 30, 2020

Uh oh!

knative-prow-robot commented Oct 30, 2020

Uh oh!

rhuss commented Oct 30, 2020

Uh oh!

rhuss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

maximilien left a comment

Choose a reason for hiding this comment

Uh oh!

maximilien left a comment

Choose a reason for hiding this comment

Uh oh!

maximilien commented Nov 11, 2020

Uh oh!

BbolroC commented Nov 11, 2020

Uh oh!

navidshaikh left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Nov 12, 2020

Uh oh!

rhuss commented Nov 24, 2020

Uh oh!

BbolroC commented Nov 24, 2020

Uh oh!

navidshaikh commented Nov 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants