Skip to content

[release-0.19] Backport #1117 #1083 #1113#1135

Merged
knative-prow-robot merged 6 commits intoknative:release-0.19from
navidshaikh:rel/v0.19.1
Nov 25, 2020
Merged

[release-0.19] Backport #1117 #1083 #1113#1135
knative-prow-robot merged 6 commits intoknative:release-0.19from
navidshaikh:rel/v0.19.1

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented Nov 24, 2020 •
edited
Loading

@navidshaikh
Embed the namespace in request body while creating channels (knative#…
a0ab3f2 
…1117)

* Embed the namespace in request body while creating channels

 since on the eventing side, defaulting for channel isnt picking
 the namespace from the context (see knative/eventing#4514)

 workaround for knative#1100
 this changeset should be reverted when eventing#4514 is resolved

* Add CHANGELOG
@navidshaikh
Update CHANGELOG for v0.19.1
fd4bbdb
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 24, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2020
@navidshaikh navidshaikh added the backport/pr A backport PR which is target to a release branch. label Nov 24, 2020
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Nov 25, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Nov 25, 2020
@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 25, 2020

@BbolroC : can you please add your consent by adding comment @googlebot I consent. here ?

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Nov 25, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@navidshaikh navidshaikh changed the title [release-0.19] Backport of #1117 [release-0.19] Backports of #1117 #1083 Nov 25, 2020
@navidshaikh navidshaikh changed the title [release-0.19] Backports of #1117 #1083 [release-0.19] Backport #1117 #1083 Nov 25, 2020
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Nov 25, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 25, 2020

/test pull-knative-client-unit-tests

wait_for_ready_test.go:65: assertion failed: expected error to contain "FakeError", got "timeout: blub 'foobar' not ready after 3 seconds"

--- FAIL: TestAddWaitForReady (7.75s)

@BbolroC
Copy link
Copy Markdown
Contributor

BbolroC commented Nov 25, 2020 •
edited
Loading

@googlebot I consent.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Nov 25, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Nov 25, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 25, 2020

@googlebot I consent.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Nov 25, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Nov 25, 2020
@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 25, 2020

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020
@navidshaikh
Fix race conditions when creating watches (knative#1113)
76f8233 
* Fix a race condition between creating a watch and initiating the action that emits the event it is watching for

* update changelog

* add PR ID to changelog entry

* Fix merge in Changelog

* Fix table format in Changelog
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2020
@navidshaikh navidshaikh changed the title [release-0.19] Backport #1117 #1083 [release-0.19] Backport #1117 #1083 #1113 Nov 25, 2020
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Nov 25, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/eventing/v1beta1/client.go 85.8% 86.9% 1.1
pkg/kn/commands/channel/describe.go 79.5% 76.9% -2.6

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Nov 25, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 25, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020
@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 25, 2020

/retest

   result_collector.go:75: ERROR: Error: Operation cannot be fulfilled on pingsources.sources.knative.dev "testpingsource0": the object has been modified; please apply your changes to the latest version and try again

@knative-prow-robot knative-prow-robot merged commit 3fcd9b2 into knative:release-0.19 Nov 25, 2020
dsimansk added a commit to dsimansk/client that referenced this pull request Sep 26, 2022
@dsimansk
Update latest spec file (knative#1135)
7ef4d21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@rhuss rhuss

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport/pr A backport PR which is target to a release branch. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@navidshaikh @knative-prow-robot @BbolroC @knative-metrics-robot @rhuss