Skip to content

Do not print serviceUID and configUID labels in service export result#1194

Merged
knative-prow-robot merged 5 commits intoknative:masterfrom
navidshaikh:pr/fix-export-annotations
Jan 20, 2021
Merged

Do not print serviceUID and configUID labels in service export result#1194
knative-prow-robot merged 5 commits intoknative:masterfrom
navidshaikh:pr/fix-export-annotations

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented Jan 19, 2021

Description

While exporting the service using service export command, ignore
the service labels with keys 'configUID' and configUID

Changes

  • Strip the mentioned labels from service before export

Reference

see knative/serving#10539 for further details

/lint

@navidshaikh
Ignore serviceUID and configUID labels in service export result
6f13dfa 
 While exporting the service using `service export` command, ignore
 the service labels with keys 'configUID' and `configUID`
 see knative/serving#10539 for further details.
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 19, 2021
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
knative-prow-robot
knative-prow-robot reviewed Jan 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 1 warning.

Details

In response to this:

Description

While exporting the service using service export command, ignore
the service labels with keys 'configUID' and configUID

Changes

  • Strip the mentioned labels from service before export

Reference

see knative/serving#10539 for further details

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread pkg/kn/commands/service/export.go Outdated
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 19, 2021
@dsimansk
Copy link
Copy Markdown
Contributor

dsimansk commented Jan 19, 2021

@navidshaikh thanks looks good!

/lgtm
/hold for other to take a look

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021
rhuss
rhuss reviewed Jan 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could we add a test (unit/e2e) + changelog entry please ?

dsimansk
dsimansk reviewed Jan 19, 2021
View reviewed changes
Comment thread pkg/kn/commands/service/export.go
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2021
@navidshaikh navidshaikh changed the title Ignore serviceUID and configUID labels in service export result Do not print serviceUID and configUID labels in service export result Jan 19, 2021
@navidshaikh navidshaikh requested review from dsimansk and rhuss January 19, 2021 14:47
maximilien
maximilien approved these changes Jan 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/hold to allow others to review

Comment thread pkg/kn/commands/service/export.go

var IGNORED_SERVICE_ANNOTATIONS = []string{
// IgnoredServiceAnnotations defines the annotation keys which should be
// removed from service annotations before export
Copy link
Copy Markdown
Contributor

@maximilien maximilien Jan 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link on the API or docs repo where these are to be found?

Copy link
Copy Markdown
Contributor Author

@navidshaikh navidshaikh Jan 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are in the main branch of serving (and will be part of 0.21 release) knative/serving#10539
/cc @duglin might know better if the docs etc are in order

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Jan 20, 2021
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jan 20, 2021

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service/export.go 86.1% 86.8% 0.7

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 20, 2021

@navidshaikh: GitHub didn't allow me to request PR reviews from the following users: might, better, are, order, docs, etc, in, know, if, the.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

they are in the main branch of serving (and will be part of 0.21 release) knative/serving#10539
/cc @duglin might know better if the docs etc are in order

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jan 20, 2021

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jan 20, 2021

@googlebot recheck

@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Jan 20, 2021

@googlebot I signed it!

@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Jan 20, 2021

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021
@knative-prow-robot knative-prow-robot merged commit dc52d5b into knative:master Jan 20, 2021
rhuss added a commit to rhuss/knative-client that referenced this pull request Mar 9, 2021
@rhuss
Add David as approver
d88920a 
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * knative#1246
  * knative#1194
  * knative#738
  * knative#832
  * knative#1016
  * knative#877
  * knative#667
  * knative#697
  * knative#1212
  * knative#835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
@rhuss rhuss mentioned this pull request Mar 9, 2021
Merged
4 tasks
rhuss added a commit to rhuss/knative-client that referenced this pull request Mar 9, 2021
@rhuss
Add David as approver
f266fca 
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * knative#1246
  * knative#1194
  * knative#738
  * knative#832
  * knative#1016
  * knative#877
  * knative#667
  * knative#697
  * knative#1212
  * knative#835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
knative-prow-robot pushed a commit that referenced this pull request Mar 9, 2021
@rhuss
Add David as approver (#1255)
9fa8d6b 
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * #1246
  * #1194
  * #738
  * #832
  * #1016
  * #877
  * #667
  * #697
  * #1212
  * #835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@cppforlife cppforlife Awaiting requested review from cppforlife

@rhuss rhuss Awaiting requested review from rhuss

@dsimansk dsimansk Awaiting requested review from dsimansk

@duglin duglin Awaiting requested review from duglin

+1 more reviewer

@maximilien maximilien maximilien approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maximilien maximilien

@rhuss rhuss

@dsimansk dsimansk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@navidshaikh @dsimansk @knative-metrics-robot @knative-prow-robot @rhuss @maximilien