chore(e2e): Refactor to better track errors#667
Merged
knative-prow-robot merged 3 commits intoknative:masterfrom Feb 17, 2020
Merged
chore(e2e): Refactor to better track errors#667knative-prow-robot merged 3 commits intoknative:masterfrom
knative-prow-robot merged 3 commits intoknative:masterfrom
Conversation
knative-prow-robot
added
the
size/XXL
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
rhuss
changed the title
rhuss
force-pushed
the
pr/e2e-refactor
branch
4 times, most recently
from
c6861c0 to
5b727dd
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
@navidshaikh I think this is good to merge and makes troubleshooting e2e issues much easier. |
* Collect results from various `kn` calls to provide the context * Changed sub-Run() commands to t.Log() to reduce the log noise and get file + line information in the log output * Removed any Fatal() calls to allows the test to properly finish * Only output via t.Log() to get the output at the proper places and allow Prow to better pick up the test results. * Most important: EMOJIS !! 🦆🦆🦆🦆🦆
rhuss
force-pushed
the
pr/e2e-refactor
branch
from
a2f51a8 to
4a60831
Compare
Contributor
|
/lgtm |
rhuss
added a commit
to rhuss/knative-client
that referenced
this pull request
Mar 9, 2021
David meets all criteria for an approver: - [x] Reviewer for at least 3 months - [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g. * knative#1246 * knative#1194 * knative#738 * knative#832 * knative#1016 * knative#877 * knative#667 * knative#697 * knative#1212 * knative#835 - [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+)) - [x] Nominated by a WG lead (rhuss) Congrats David ! Thanks a lot for your awesome work & contributions.
rhuss
added a commit
to rhuss/knative-client
that referenced
this pull request
Mar 9, 2021
David meets all criteria for an approver: - [x] Reviewer for at least 3 months - [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g. * knative#1246 * knative#1194 * knative#738 * knative#832 * knative#1016 * knative#877 * knative#667 * knative#697 * knative#1212 * knative#835 - [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+)) - [x] Nominated by a WG lead (rhuss) Congrats David ! Thanks a lot for your awesome work & contributions.
knative-prow-robot
pushed a commit
that referenced
this pull request
Mar 9, 2021
David meets all criteria for an approver: - [x] Reviewer for at least 3 months - [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g. * #1246 * #1194 * #738 * #832 * #1016 * #877 * #667 * #697 * #1212 * #835 - [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+)) - [x] Nominated by a WG lead (rhuss) Congrats David ! Thanks a lot for your awesome work & contributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kncalls to provide the context