Skip to content

Remove unused value CfgFile#173

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
nak3:remove-cfgfile
Jun 10, 2019
Merged

Remove unused value CfgFile#173
knative-prow-robot merged 1 commit intoknative:masterfrom
nak3:remove-cfgfile

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented Jun 9, 2019

This patch removes unused CfgFile value from codes.

Related to #139

@nak3
Remove unused value CfgFile
178cacc 
This patch removes unused `CfgFile` value from codes.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 9, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 9, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 9, 2019

Hi @nak3. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 9, 2019
@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jun 10, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2019
@cppforlife
Copy link
Copy Markdown

cppforlife commented Jun 10, 2019

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cppforlife, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2019
@knative-prow-robot knative-prow-robot merged commit 176cb0e into knative:master Jun 10, 2019
sixolet added a commit to sixolet/client that referenced this pull request Jun 19, 2019
@sixolet
Revert knative#173 and knative#139
257e6d4
knative-prow-robot pushed a commit that referenced this pull request Jun 20, 2019
@sixolet @knative-prow-robot
Revert #173 and #139, reinstating having a config file. (#193)
32ccc33 
* Revert #173 and #139

* Change default layout to have a hidden kn dir

* Update deps
maximilien pushed a commit to maximilien/client that referenced this pull request Jul 1, 2019
@sixolet @maximilien
Revert knative#173 and knative#139, reinstating having a config file. (…
837fb44 
…knative#193)

* Revert knative#173 and knative#139

* Change default layout to have a hidden kn dir

* Update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattmoor mattmoor Awaiting requested review from mattmoor

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@cppforlife cppforlife

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nak3 @knative-prow-robot @rhuss @cppforlife @googlebot