Revert #173 and #139, reinstating having a config file.#193
Merged
knative-prow-robot merged 3 commits intoknative:masterfrom Jun 20, 2019
Merged
Revert #173 and #139, reinstating having a config file.#193knative-prow-robot merged 3 commits intoknative:masterfrom
knative-prow-robot merged 3 commits intoknative:masterfrom
Conversation
sixolet
requested review from
maximilien
and removed request for
cppforlife and
mattmoor
knative-prow-robot
added
size/XXL
maximilien
reviewed
Jun 19, 2019
Contributor
maximilien
left a comment
maximilien
left a comment
There was a problem hiding this comment.
Nice. Thanks for doing this. Going to try to use it today and let you know here.
maximilien
approved these changes
Jun 20, 2019
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
maximilien
pushed a commit
to maximilien/client
that referenced
this pull request
Jul 1, 2019
…knative#193) * Revert knative#173 and knative#139 * Change default layout to have a hidden kn dir * Update deps
Kaustubh-pande
pushed a commit
to Kaustubh-pande/client
that referenced
this pull request
Jul 6, 2023
* [release-v1.9] Add func v1.10.0 * Update vendor dir * Add ldflag file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: Use it in plugin code to determine where to look for plugins.
And change default config location to be
.kn/config.yaml