Skip to content

Fix for #1405#1407

Closed
abrennan89 wants to merge 5 commits into
knative:masterfrom
abrennan89:1332
Closed

Fix for #1405#1407
abrennan89 wants to merge 5 commits into
knative:masterfrom
abrennan89:1332

Conversation

@abrennan89
Copy link
Copy Markdown
Contributor

Fixes #1405

Proposed Changes

  • Minor change to remove unwanted H1 from new topic.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 31, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abrennan89
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rgregg

If they are not already assigned, you can assign the PR to them by writing /assign @rgregg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@abrennan89: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-docs-go-coverage 9ad92c8 link /test pull-knative-docs-go-coverage
pull-knative-docs-unit-tests 9ad92c8 link /test pull-knative-docs-unit-tests
pull-knative-docs-build-tests 9ad92c8 link /test pull-knative-docs-build-tests
pull-knative-docs-integration-tests 9ad92c8 link /test pull-knative-docs-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@samodell
Copy link
Copy Markdown
Contributor

hm, this seems to include the commits that were merged in #1363 -- this PR should just include the commits that fix the issue, since the content has already been merged in. I think that will fix the merge conflict as well.

@abrennan89
Copy link
Copy Markdown
Contributor Author

Hi @samodell - yes apologies I just pinged you on Slack! I goofed and forgot to remove the branch etc before I added a new commit. Can you close or delete this PR and I will do this properly? Sorry for the inconvenience!

@samodell samodell closed this May 31, 2019
@samodell
Copy link
Copy Markdown
Contributor

no worries at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix metadata in autoscaling docs

4 participants