Added autoscaling docs and scale-to-zero details#1363
Conversation
knative-prow-robot
added
the
size/L
abrennan89
changed the title
|
/assign @samodell |
samodell
left a comment
samodell
left a comment
There was a problem hiding this comment.
This is looking great! Just a few small suggestions.
| The `revision.serving.knative.dev` resource is a point-in-time snapshot of the | ||
| code and configuration for each modification made to the workload. Revisions | ||
| are immutable objects and can be retained for as long as useful. | ||
| Knative Serving Revisions can be automatically scaled up and down according to incoming traffic. See [Autoscaling](./autoscaling.md) for more information. |
There was a problem hiding this comment.
.md formatting nit -- this should be at the same level of indentation as the list item above, if you wanted it to be part of that. And if not, create a new line between the list item and this sentence.
| @@ -0,0 +1,114 @@ | |||
| <!-- Add metadata as included for other files --> | |||
| # Autoscaling | |||
There was a problem hiding this comment.
| # Autoscaling | |
| --- | |
| title: "Configuring the Autoscaler" | |
| weight: 10 | |
| type: "docs" | |
| --- |
There was a problem hiding this comment.
I'd update the title of the page to reflect whatever title you settle on. We try to shoot for action verbs in the page titles, which is why I added "Configuring," but if there's another word you'd rather use, go for it!
| - [Orchestrating source-to-URL workflows on Kubernetes](./serving/samples/source-to-url-go/) | ||
| - [Routing and managing traffic with blue/green deployment](./serving/samples/blue-green-deployment.md) | ||
| - [Scaling automatically and sizing workloads based on demand](./serving/samples/autoscale-go/) | ||
| - [Scaling automatically and sizing workloads based on demand](./serving/autoscaling.md) |
There was a problem hiding this comment.
If you update the name of the file below based on my suggestions, make sure to also update it here.
|
|
||
| If there is no `/target` annotation, the autoscaler is configured as if `/target` == `containerConcurrency`. | ||
|
|
||
| ## Configuring CPU based autoscaling |
There was a problem hiding this comment.
| ## Configuring CPU based autoscaling | |
| ## Configuring CPU-based autoscaling |
| ## Additional resources | ||
|
|
||
| - [Go autoscaling sample](https://knative.dev/docs/serving/samples/autoscale-go/index.html) | ||
| - Knative v0.3 Autoscaling - A Love Story [blog post](https://medium.com/knative/knative-v0-3-autoscaling-a-love-story-d6954279a67a) |
There was a problem hiding this comment.
| - Knative v0.3 Autoscaling - A Love Story [blog post](https://medium.com/knative/knative-v0-3-autoscaling-a-love-story-d6954279a67a) | |
| - [Knative v0.3 Autoscaling - A Love Story blog post](https://medium.com/knative/knative-v0-3-autoscaling-a-love-story-d6954279a67a) |
| <!-- Add metadata as included for other files --> | ||
| # Autoscaling | ||
|
|
||
| Since Knative v0.2, per revision autoscalers have been replaced by a single shared autoscaler. This is, by default, the Knative Pod Autoscaler (KPA), which provides fast, request based autoscaling capabilities out of the box. |
There was a problem hiding this comment.
| Since Knative v0.2, per revision autoscalers have been replaced by a single shared autoscaler. This is, by default, the Knative Pod Autoscaler (KPA), which provides fast, request based autoscaling capabilities out of the box. | |
| Since Knative v0.2, per revision autoscalers have been replaced by a single shared autoscaler. This is, by default, the Knative Pod Autoscaler (KPA), which provides fast, request-based autoscaling capabilities out of the box. |
|
Thanks @samodell :) the changes should be ready now |
|
/assign abrennan89 |
|
/lgtm Thanks for adding this, Ashleigh! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Fixes #1362
Proposed Changes