Skip to content

Cherry pick changes from master into 0.6#1423

Merged
knative-prow-robot merged 9 commits into
knative:release-0.6from
RichieEscarez:cherry06
Jun 7, 2019
Merged

Cherry pick changes from master into 0.6#1423
knative-prow-robot merged 9 commits into
knative:release-0.6from
RichieEscarez:cherry06

Conversation

@RichieEscarez
Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez commented Jun 6, 2019

abrennan89 and others added 8 commits June 5, 2019 17:13
@abrennan89 @RichieEscarez
pr#1408
f94b407
@RichieEscarez
pr#1398
84ebe81
@grayside @evankanderson @RichieEscarez
service/samples: add .dockerignore to samples with local build disrup…
f71e221 
…tion risk (knative#1392)

* service/samples: add .dockerignore to samples with risk of local build interference

* serving/samples: .dockerignore readme text update

* Update docs/serving/samples/hello-world/helloworld-csharp/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/samples/hello-world/helloworld-nodejs/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/samples/hello-world/helloworld-python/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/samples/hello-world/helloworld-php/README.md

Co-Authored-By: Evan Anderson <evan.k.anderson@gmail.com>
@RichieEscarez
Fix the wrong information in grpc example (knative#1380)
e4241ad
@abrennan89 @RichieEscarez
pr#1363
7b7b5df
@edwardstudy @RichieEscarez
Fix samples path (knative#1357)
f53efe6
@Harwayne @RichieEscarez
Copy the updates from knative/eventing#1241. (knative#1355)
02b5864
@sebgoa @RichieEscarez
add reference to custom DNS config (knative#1327)
f6aa662 
* add reference to custom DNS config

* Update docs/install/getting-started-knative-app.md

Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>

* fix relative link

* Fix PR#1202
@googlebot
Copy link
Copy Markdown

googlebot commented Jun 6, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Jun 6, 2019
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 6, 2019
@RichieEscarez RichieEscarez added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jun 6, 2019
@googlebot
Copy link
Copy Markdown

googlebot commented Jun 6, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@RichieEscarez RichieEscarez changed the base branch from master to release-0.6 June 6, 2019 00:34
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 6, 2019
@googlebot
Copy link
Copy Markdown

googlebot commented Jun 6, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jun 6, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jonjohnsonjr @RichieEscarez
Document serving tag resolution (knative#1260)
829bdeb 
Our controller does resolution of tags to digests, which has been a
source of confusion. This documents the fact that we do it, why we do
it, and how to configure the controller to work around common issues.
@RichieEscarez RichieEscarez added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jun 6, 2019
@googlebot
Copy link
Copy Markdown

googlebot commented Jun 6, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@samodell
Copy link
Copy Markdown
Contributor

samodell commented Jun 6, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2019
@RichieEscarez
Copy link
Copy Markdown
Contributor Author

RichieEscarez commented Jun 6, 2019

/retest

1 similar comment
@RichieEscarez
Copy link
Copy Markdown
Contributor Author

RichieEscarez commented Jun 7, 2019

/retest

@RichieEscarez
Copy link
Copy Markdown
Contributor Author

RichieEscarez commented Jun 7, 2019

@chaodaiG Thanks for taking a look at this! Ive run local presubmit and e2etests without success =(

@chaodaiG
Copy link
Copy Markdown
Contributor

chaodaiG commented Jun 7, 2019

@RichieEscarez no problem

It should be fixed by my PR now

/retest

@knative-prow-robot knative-prow-robot merged commit ddf26f8 into knative:release-0.6 Jun 7, 2019
@RichieEscarez RichieEscarez deleted the cherry06 branch June 19, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@samodell samodell Awaiting requested review from samodell

Assignees

@samodell samodell

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.