Skip to content

Document serving tag resolution#1260

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
jonjohnsonjr:tag-resolution
Jun 3, 2019
Merged

Document serving tag resolution#1260
knative-prow-robot merged 1 commit into
knative:masterfrom
jonjohnsonjr:tag-resolution

Conversation

@jonjohnsonjr
Copy link
Copy Markdown
Contributor

Our controller does resolution of tags to digests, which has been a
source of confusion. This documents the fact that we do it, why we do
it, and how to configure the controller to work around common issues.

Our controller does resolution of tags to digests, which has been a
source of confusion. This documents the fact that we do it, why we do
it, and how to configure the controller to work around common issues.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 1, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 1, 2019
@jonjohnsonjr
Copy link
Copy Markdown
Contributor Author

cc @mattmoor anything else you can think of for this?

@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented May 2, 2019

/lgtm

@samodell Should we link this from somewhere?

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2019
@samodell samodell self-assigned this May 22, 2019
@samodell
Copy link
Copy Markdown
Contributor

samodell commented Jun 3, 2019

/approve

We can definitely add links to this from relevant content, but I do want to get the content merged in now. It will be automatically linked from the table of contents on the side of the pages, at a minimum.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonjohnsonjr, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit e18e56b into knative:master Jun 3, 2019
@jonjohnsonjr jonjohnsonjr deleted the tag-resolution branch June 3, 2019 18:05
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 6, 2019
Our controller does resolution of tags to digests, which has been a
source of confusion. This documents the fact that we do it, why we do
it, and how to configure the controller to work around common issues.
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 6, 2019
Our controller does resolution of tags to digests, which has been a
source of confusion. This documents the fact that we do it, why we do
it, and how to configure the controller to work around common issues.
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 6, 2019
Our controller does resolution of tags to digests, which has been a
source of confusion. This documents the fact that we do it, why we do
it, and how to configure the controller to work around common issues.
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 6, 2019
Our controller does resolution of tags to digests, which has been a
source of confusion. This documents the fact that we do it, why we do
it, and how to configure the controller to work around common issues.
knative-prow-robot pushed a commit that referenced this pull request Jun 7, 2019
* pr#1408

* pr#1398

* service/samples: add .dockerignore to samples with local build disruption risk (#1392)

* service/samples: add .dockerignore to samples with risk of local build interference

* serving/samples: .dockerignore readme text update

* Update docs/serving/samples/hello-world/helloworld-csharp/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/samples/hello-world/helloworld-nodejs/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/samples/hello-world/helloworld-python/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/samples/hello-world/helloworld-php/README.md

Co-Authored-By: Evan Anderson <evan.k.anderson@gmail.com>

* Fix the wrong information in grpc example (#1380)

* pr#1363

* Fix samples path (#1357)

* Copy the updates from knative/eventing#1241. (#1355)

* add reference to custom DNS config (#1327)

* add reference to custom DNS config

* Update docs/install/getting-started-knative-app.md

Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>

* fix relative link

* Fix PR#1202

* Document serving tag resolution (#1260)

Our controller does resolution of tags to digests, which has been a
source of confusion. This documents the fact that we do it, why we do
it, and how to configure the controller to work around common issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. kind/serving lgtm Indicates that a PR is ready to be merged. priority/high size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants