add reference to custom DNS config#1327
Merged
Merged
Conversation
knative-prow-robot
added
the
size/XS
samodell
reviewed
May 17, 2019
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
Contributor
Author
|
@samodell I accepted your suggestion. Thanks |
knative-prow-robot
added
size/L
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RichieEscarez, sebgoa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Jun 6, 2019
* add reference to custom DNS config * Update docs/install/getting-started-knative-app.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * fix relative link * Fix PR#1202
knative-prow-robot
pushed a commit
that referenced
this pull request
Jun 7, 2019
* pr#1408 * pr#1398 * service/samples: add .dockerignore to samples with local build disruption risk (#1392) * service/samples: add .dockerignore to samples with risk of local build interference * serving/samples: .dockerignore readme text update * Update docs/serving/samples/hello-world/helloworld-csharp/README.md Co-Authored-By: RichieEscarez <rescarez@google.com> * Update docs/serving/samples/hello-world/helloworld-nodejs/README.md Co-Authored-By: RichieEscarez <rescarez@google.com> * Update docs/serving/samples/hello-world/helloworld-python/README.md Co-Authored-By: RichieEscarez <rescarez@google.com> * Update docs/serving/samples/hello-world/helloworld-php/README.md Co-Authored-By: Evan Anderson <evan.k.anderson@gmail.com> * Fix the wrong information in grpc example (#1380) * pr#1363 * Fix samples path (#1357) * Copy the updates from knative/eventing#1241. (#1355) * add reference to custom DNS config (#1327) * add reference to custom DNS config * Update docs/install/getting-started-knative-app.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * fix relative link * Fix PR#1202 * Document serving tag resolution (#1260) Our controller does resolution of tags to digests, which has been a source of confusion. This documents the fact that we do it, why we do it, and how to configure the controller to work around common issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1298
Proposed Changes
Adds a note that points to the guide to configure a custom domain