Skip to content

Fix samples path#1357

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
edwardstudy:patch-1
May 21, 2019
Merged

Fix samples path#1357
knative-prow-robot merged 1 commit into
knative:masterfrom
edwardstudy:patch-1

Conversation

@edwardstudy
Copy link
Copy Markdown
Contributor

@edwardstudy edwardstudy commented May 21, 2019 •
edited
Loading

issue: None

Proposed Changes

  • Fix samples path when git clone && cd

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 21, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 21, 2019

Hi @edwardstudy. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2019
RichieEscarez
RichieEscarez approved these changes May 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @edwardstudy!

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edwardstudy, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 747364b into knative:master May 21, 2019
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 6, 2019
@edwardstudy @RichieEscarez
Fix samples path (knative#1357)
f53efe6
@RichieEscarez RichieEscarez mentioned this pull request Jun 6, 2019
Merged
knative-prow-robot pushed a commit that referenced this pull request Jun 7, 2019
@RichieEscarez @knative-prow-robot
Cherry pick changes from master into 0.6 (#1423)
ddf26f8 
* pr#1408

* pr#1398

* service/samples: add .dockerignore to samples with local build disruption risk (#1392)

* service/samples: add .dockerignore to samples with risk of local build interference

* serving/samples: .dockerignore readme text update

* Update docs/serving/samples/hello-world/helloworld-csharp/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/samples/hello-world/helloworld-nodejs/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/samples/hello-world/helloworld-python/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/samples/hello-world/helloworld-php/README.md

Co-Authored-By: Evan Anderson <evan.k.anderson@gmail.com>

* Fix the wrong information in grpc example (#1380)

* pr#1363

* Fix samples path (#1357)

* Copy the updates from knative/eventing#1241. (#1355)

* add reference to custom DNS config (#1327)

* add reference to custom DNS config

* Update docs/install/getting-started-knative-app.md

Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>

* fix relative link

* Fix PR#1202

* Document serving tag resolution (#1260)

Our controller does resolution of tags to digests, which has been a
source of confusion. This documents the fact that we do it, why we do
it, and how to configure the controller to work around common issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@gyliu513 gyliu513 Awaiting requested review from gyliu513

1 more reviewer

@RichieEscarez RichieEscarez RichieEscarez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RichieEscarez RichieEscarez

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edwardstudy @knative-prow-robot @RichieEscarez @googlebot