Skip to content

Documenting the Trigger annotation case for the Broker creation#2285

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:add_trigger_annotation_doc
Mar 10, 2020
Merged

Documenting the Trigger annotation case for the Broker creation#2285
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:add_trigger_annotation_doc

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Mar 9, 2020

Proposed Changes

/assign @grac3gao

@matzew
Documenting the Trigger annotation case for the Broker creation
58dcbc0 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 9, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2020
@matzew matzew mentioned this pull request Mar 9, 2020
Merged
@grac3gao-zz
Copy link
Copy Markdown

grac3gao-zz commented Mar 9, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Mar 9, 2020

/assign @samodell

for approval

mikehelmick
mikehelmick approved these changes Mar 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mikehelmick mikehelmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Mar 10, 2020

/approve

But I don't think I'm actually an approver

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Mar 10, 2020

/approved

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Mar 10, 2020

typo nit: /approve 😁

evankanderson
evankanderson reviewed Mar 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, grantr, matzew, mikehelmick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3cfa3f0 into knative:master Mar 10, 2020
@grantr grantr mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson left review comments

@n3wscott n3wscott Awaiting requested review from n3wscott

@nachocano nachocano Awaiting requested review from nachocano

+1 more reviewer

@mikehelmick mikehelmick mikehelmick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikehelmick mikehelmick

@evankanderson evankanderson

@samodell samodell

@grac3gao-zz grac3gao-zz

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@matzew @grac3gao-zz @grantr @dprotaso @knative-prow-robot @mikehelmick @evankanderson @googlebot @samodell