Skip to content

Fixing the kn cli references#3422

Merged
knative-prow-robot merged 19 commits into
mainfrom
Fixing-the-Kn-CLI-References
Apr 5, 2021
Merged

Fixing the kn cli references#3422
knative-prow-robot merged 19 commits into
mainfrom
Fixing-the-Kn-CLI-References

Conversation

@omerbensaadon
Copy link
Copy Markdown

I figured out how to group commits

its over for you foes

Omer B and others added 19 commits April 2, 2021 10:02
Changing link on the install page to link to pre-requisites
Added links to install either Serving or Eventing in Pre-Req
- Edited to include `kn` CLI as a pre-req
- pulled out Homebrew command 
- bolded important portions of the page
- conformed "Serving" and "Eventing" to the  [Knative Word and Phrase List](https://docs.google.com/spreadsheets/d/1p1_kBUd6ZvonxHkMcEJPayf6QIpExuFf5cFq0ptar7I/edit#gid=0) 
- Added link to Private Registry documentation
- removed reference to KN CLI (now in Pre-Reqs) 
- trimmed the fat around Installing Kantive Eventing
- Added relevant context to optional extensions
Added same context from Eventing Page
Added same context from Eventing Page, added (like TLS) to second bullet.
Removed reference to KN CLI (now in Pre-Reqs)
added reference to install files
made wording less bad
… install out of Github and into knative.dev site (#3410)

* Update install-kn.md

Adding brew install kn command directly to page and making it the first option

* Update docs/client/install-kn.md

Co-authored-by: Mike Petersen <mpetason@gmail.com>

Co-authored-by: Mike Petersen <mpetason@gmail.com>
Adding `kn` CLI to Next Steps
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 5, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 5, 2021
@omerbensaadon omerbensaadon added approved lgtm Indicates that a PR is ready to be merged. labels Apr 5, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit dd79063 into main Apr 5, 2021
omerbensaadon pushed a commit that referenced this pull request Apr 5, 2021
omerbensaadon pushed a commit that referenced this pull request Apr 5, 2021
@omerbensaadon omerbensaadon deleted the Fixing-the-Kn-CLI-References branch April 5, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants