Make Homebrew installation the first option for kn, pull command to install out of Github and into knative.dev site#3410
Merged
Conversation
Adding brew install kn command directly to page and making it the first option
knative-prow-robot
added
the
size/S
omerbensaadon
changed the title
kn, pull command to install out of Github and into knative.dev site
mpetason
reviewed
Apr 2, 2021
Co-authored-by: Mike Petersen <mpetason@gmail.com>
Author
|
@mpetason thank you! Fixed |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
pushed a commit
that referenced
this pull request
Apr 5, 2021
* Update _index.md Changing link on the install page to link to pre-requisites * Update prerequisites.md Added links to install either Serving or Eventing in Pre-Req * Update prerequisites.md - Edited to include `kn` CLI as a pre-req - pulled out Homebrew command - bolded important portions of the page - conformed "Serving" and "Eventing" to the [Knative Word and Phrase List](https://docs.google.com/spreadsheets/d/1p1_kBUd6ZvonxHkMcEJPayf6QIpExuFf5cFq0ptar7I/edit#gid=0) - Added link to Private Registry documentation * Update install-serving-with-yaml.md - removed reference to KN CLI (now in Pre-Reqs) - trimmed the fat around Installing Kantive Eventing - Added relevant context to optional extensions * Update install-serving-with-yaml.md Added same context from Eventing Page * Update install-serving-with-yaml.md Added same context from Eventing Page, added (like TLS) to second bullet. * Update install-eventing-with-yaml.md Removed reference to KN CLI (now in Pre-Reqs) * Update install-serving-with-yaml.md added reference to install files * Update install-extensions.md Fix broken link * Create install-extensions.md Fix broken link * Update install-eventing-with-yaml.md * Update prerequisites.md made wording less bad * Make Homebrew installation the first option for `kn`, pull command to install out of Github and into knative.dev site (#3410) * Update install-kn.md Adding brew install kn command directly to page and making it the first option * Update docs/client/install-kn.md Co-authored-by: Mike Petersen <mpetason@gmail.com> Co-authored-by: Mike Petersen <mpetason@gmail.com> * Create prerequisites.md (#3413) whitespace fix * Update prerequisites.md (#3414) more whitespace * remove (like TLS) * Update install-serving-with-yaml.md (#3420) Adding `kn` CLI to Next Steps * Update install-eventing-with-yaml.md (#3421) * Removing `kn` from required Co-authored-by: Mike Petersen <mpetason@gmail.com>
knative-prow-robot
pushed a commit
that referenced
this pull request
Apr 8, 2021
… in UX/11 (#3411) * Update _index.md Changing link on the install page to link to pre-requisites * Update prerequisites.md Added links to install either Serving or Eventing in Pre-Req * Update prerequisites.md - Edited to include `kn` CLI as a pre-req - pulled out Homebrew command - bolded important portions of the page - conformed "Serving" and "Eventing" to the [Knative Word and Phrase List](https://docs.google.com/spreadsheets/d/1p1_kBUd6ZvonxHkMcEJPayf6QIpExuFf5cFq0ptar7I/edit#gid=0) - Added link to Private Registry documentation * Update install-serving-with-yaml.md - removed reference to KN CLI (now in Pre-Reqs) - trimmed the fat around Installing Kantive Eventing - Added relevant context to optional extensions * Update install-serving-with-yaml.md Added same context from Eventing Page * Update install-serving-with-yaml.md Added same context from Eventing Page, added (like TLS) to second bullet. * Update install-eventing-with-yaml.md Removed reference to KN CLI (now in Pre-Reqs) * Update install-serving-with-yaml.md added reference to install files * Update install-extensions.md Fix broken link * Create install-extensions.md Fix broken link * Update install-eventing-with-yaml.md * Update prerequisites.md made wording less bad * Make Homebrew installation the first option for `kn`, pull command to install out of Github and into knative.dev site (#3410) * Update install-kn.md Adding brew install kn command directly to page and making it the first option * Update docs/client/install-kn.md Co-authored-by: Mike Petersen <mpetason@gmail.com> Co-authored-by: Mike Petersen <mpetason@gmail.com> * Create prerequisites.md (#3413) whitespace fix * Update prerequisites.md (#3414) more whitespace * remove (like TLS) * Update install-serving-with-yaml.md (#3420) Adding `kn` CLI to Next Steps * Update install-eventing-with-yaml.md (#3421) * Removing `kn` from required (#3424) * Adding @snneji changes (#3429) * Update install-serving-with-yaml.md (#3435) accidentally left this out * Adding @snneji changes round 2 (#3439) * Adding @snneji changes * Adding @snneji changes round 2 Co-authored-by: Mike Petersen <mpetason@gmail.com>
knative-prow-robot
pushed a commit
to knative-prow-robot/docs
that referenced
this pull request
Apr 8, 2021
… install out of Github and into knative.dev site (knative#3410) * Update install-kn.md Adding brew install kn command directly to page and making it the first option * Update docs/client/install-kn.md Co-authored-by: Mike Petersen <mpetason@gmail.com> Co-authored-by: Mike Petersen <mpetason@gmail.com>
knative-prow-robot
added a commit
that referenced
this pull request
Apr 21, 2021
…sired prototype in UX/11 (#3440) * Update _index.md Changing link on the install page to link to pre-requisites * Update prerequisites.md Added links to install either Serving or Eventing in Pre-Req * Update prerequisites.md - Edited to include `kn` CLI as a pre-req - pulled out Homebrew command - bolded important portions of the page - conformed "Serving" and "Eventing" to the [Knative Word and Phrase List](https://docs.google.com/spreadsheets/d/1p1_kBUd6ZvonxHkMcEJPayf6QIpExuFf5cFq0ptar7I/edit#gid=0) - Added link to Private Registry documentation * Update install-serving-with-yaml.md - removed reference to KN CLI (now in Pre-Reqs) - trimmed the fat around Installing Kantive Eventing - Added relevant context to optional extensions * Update install-serving-with-yaml.md Added same context from Eventing Page * Update install-serving-with-yaml.md Added same context from Eventing Page, added (like TLS) to second bullet. * Update install-eventing-with-yaml.md Removed reference to KN CLI (now in Pre-Reqs) * Update install-serving-with-yaml.md added reference to install files * Update install-extensions.md Fix broken link * Update install-eventing-with-yaml.md * Update prerequisites.md made wording less bad * Make Homebrew installation the first option for `kn`, pull command to install out of Github and into knative.dev site (#3410) * Update install-kn.md Adding brew install kn command directly to page and making it the first option * Update docs/client/install-kn.md Co-authored-by: Mike Petersen <mpetason@gmail.com> Co-authored-by: Mike Petersen <mpetason@gmail.com> * Create prerequisites.md (#3413) whitespace fix * Update prerequisites.md (#3414) more whitespace * remove (like TLS) * Update install-serving-with-yaml.md (#3420) Adding `kn` CLI to Next Steps * Update install-eventing-with-yaml.md (#3421) * Removing `kn` from required (#3424) * Adding @snneji changes (#3429) * Update install-serving-with-yaml.md (#3435) accidentally left this out * Adding @snneji changes round 2 (#3439) * Adding @snneji changes * Adding @snneji changes round 2 * Update install-kn.md fix to homebrew statement * Update docs/install/_index.md * Update install-serving-with-yaml.md * Update install-eventing-with-yaml.md * Update install-serving-with-yaml.md * Update install-extensions.md * Update docs/client/install-kn.md * Update docs/client/install-kn.md * Update install-kn.md * Update docs/install/install-serving-with-yaml.md * Update install-kn.md adding line Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Mike Petersen <mpetason@gmail.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding brew install kn command directly to page and making it the first option
Actually kind of crazy that we don't already do this