[release-0.22] Updating install flow with minor changes to reflect desired prototype in UX/11 by knative-prow-robot · Pull Request #3440 · knative/docs

knative-prow-robot · 2021-04-08T13:16:32Z

This is an automated cherry-pick of #3411

Changing link on the install page to link to pre-requisites

Added links to install either Serving or Eventing in Pre-Req

- Edited to include `kn` CLI as a pre-req - pulled out Homebrew command - bolded important portions of the page - conformed "Serving" and "Eventing" to the [Knative Word and Phrase List](https://docs.google.com/spreadsheets/d/1p1_kBUd6ZvonxHkMcEJPayf6QIpExuFf5cFq0ptar7I/edit#gid=0) - Added link to Private Registry documentation

- removed reference to KN CLI (now in Pre-Reqs) - trimmed the fat around Installing Kantive Eventing - Added relevant context to optional extensions

Added same context from Eventing Page

Added same context from Eventing Page, added (like TLS) to second bullet.

Removed reference to KN CLI (now in Pre-Reqs)

added reference to install files

Fix broken link

made wording less bad

… install out of Github and into knative.dev site (knative#3410) * Update install-kn.md Adding brew install kn command directly to page and making it the first option * Update docs/client/install-kn.md Co-authored-by: Mike Petersen <mpetason@gmail.com> Co-authored-by: Mike Petersen <mpetason@gmail.com>

whitespace fix

more whitespace

Adding `kn` CLI to Next Steps

accidentally left this out

@snneji

* Adding @snneji changes * Adding @snneji changes round 2

google-cla · 2021-04-08T13:16:50Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

omerbensaadon · 2021-04-08T13:18:20Z

/retest

omerbensaadon · 2021-04-08T13:19:11Z

@googlebot I consent.

google-cla · 2021-04-20T18:54:16Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-20T18:54:49Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

omerbensaadon · 2021-04-20T18:56:06Z

oh FFS Google Bot

@abrennan89 I've removed them all... still confused about this since other links link this way and seem to work but seems like this will work...?

CC: @evankanderson

google-cla · 2021-04-21T22:02:33Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-21T22:02:59Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-21T22:04:59Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-21T22:08:25Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

adding line

google-cla · 2021-04-21T22:09:45Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

abrennan89

/lgtm

knative-prow-robot · 2021-04-21T22:09:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [abrennan89]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abrennan89 · 2021-04-21T22:10:21Z

@googlebot I consent.

google-cla · 2021-04-21T22:10:38Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

grantr · 2021-04-21T22:14:57Z

All contributors have previously signed the CLA.

Omer B and others added 21 commits April 8, 2021 13:16

Update _index.md

fbb34fa

Changing link on the install page to link to pre-requisites

Update prerequisites.md

0d99fca

Added links to install either Serving or Eventing in Pre-Req

Update install-serving-with-yaml.md

fe40a18

- removed reference to KN CLI (now in Pre-Reqs) - trimmed the fat around Installing Kantive Eventing - Added relevant context to optional extensions

Update install-serving-with-yaml.md

973cf10

Added same context from Eventing Page

Update install-serving-with-yaml.md

b8cf7d8

Added same context from Eventing Page, added (like TLS) to second bullet.

Update install-eventing-with-yaml.md

4fc0793

Removed reference to KN CLI (now in Pre-Reqs)

Update install-serving-with-yaml.md

34edc37

added reference to install files

Update install-extensions.md

c04fb7d

Fix broken link

Update install-eventing-with-yaml.md

e1fd196

Update prerequisites.md

c9d84b6

made wording less bad

Create prerequisites.md (knative#3413)

9e074b5

whitespace fix

Update prerequisites.md (knative#3414)

f9cdb44

more whitespace

remove (like TLS)

889c8a4

Update install-serving-with-yaml.md (knative#3420)

4687131

Adding `kn` CLI to Next Steps

Update install-eventing-with-yaml.md (knative#3421)

99e0fbd

Removing kn from required (knative#3424)

9869b29

Adding @snneji changes (knative#3429)

ffdff13

Update install-serving-with-yaml.md (knative#3435)

b2fd26b

accidentally left this out

Adding @snneji changes round 2 (knative#3439)

454b2f2

* Adding @snneji changes * Adding @snneji changes round 2

knative-prow-robot mentioned this pull request Apr 8, 2021

Updating install flow with minor changes to reflect desired prototype in UX/11 #3411

Merged

knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 8, 2021

knative-prow-robot assigned omerbensaadon Apr 8, 2021

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2021

google-cla Bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Apr 8, 2021

Update install-serving-with-yaml.md

1ced1c4

Update install-extensions.md

db7633c

abrennan89 reviewed Apr 21, 2021

View reviewed changes

Comment thread docs/client/install-kn.md Outdated

Update docs/client/install-kn.md

1008058

abrennan89 reviewed Apr 21, 2021

View reviewed changes

Comment thread docs/client/install-kn.md

Update docs/client/install-kn.md

86efec4

abrennan89 reviewed Apr 21, 2021

View reviewed changes

Comment thread docs/client/install-kn.md

Update install-kn.md

b4196fb

abrennan89 reviewed Apr 21, 2021

View reviewed changes

Comment thread docs/install/install-serving-with-yaml.md Outdated

Update docs/install/install-serving-with-yaml.md

e754aa2

Update install-kn.md

07b519d

adding line

abrennan89 approved these changes Apr 21, 2021

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021

abrennan89 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2021

grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Apr 21, 2021

knative-prow-robot merged commit e18f298 into knative:release-0.22 Apr 21, 2021

Conversation

knative-prow-robot commented Apr 8, 2021

Uh oh!

google-cla Bot commented Apr 8, 2021

Uh oh!

omerbensaadon commented Apr 8, 2021

Uh oh!

omerbensaadon commented Apr 8, 2021

Uh oh!

google-cla Bot commented Apr 20, 2021

Uh oh!

google-cla Bot commented Apr 20, 2021

Uh oh!

omerbensaadon commented Apr 20, 2021

Uh oh!

Uh oh!

google-cla Bot commented Apr 21, 2021

Uh oh!

Uh oh!

google-cla Bot commented Apr 21, 2021

Uh oh!

Uh oh!

google-cla Bot commented Apr 21, 2021

Uh oh!

Uh oh!

google-cla Bot commented Apr 21, 2021

Uh oh!

google-cla Bot commented Apr 21, 2021

Uh oh!

abrennan89 left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Apr 21, 2021

Uh oh!

abrennan89 commented Apr 21, 2021

Uh oh!

google-cla Bot commented Apr 21, 2021

Uh oh!

grantr commented Apr 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants