Skip to content

Removing kn from required#3424

Merged
omerbensaadon merged 1 commit into
omerbensaadon-patch-7from
Fixing-the-Kn-CLI-References
Apr 5, 2021
Merged

Removing kn from required#3424
omerbensaadon merged 1 commit into
omerbensaadon-patch-7from
Fixing-the-Kn-CLI-References

Conversation

@omerbensaadon
Copy link
Copy Markdown

No description provided.

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 5, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign evankanderson after the PR has been reviewed.
You can assign the PR to them by writing /assign @evankanderson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 5, 2021
@omerbensaadon omerbensaadon merged commit 5e68fba into omerbensaadon-patch-7 Apr 5, 2021
@omerbensaadon omerbensaadon deleted the Fixing-the-Kn-CLI-References branch April 5, 2021 22:30
knative-prow-robot pushed a commit that referenced this pull request Apr 8, 2021
… in UX/11 (#3411)

* Update _index.md

Changing link on the install page to link to pre-requisites

* Update prerequisites.md

Added links to install either Serving or Eventing in Pre-Req

* Update prerequisites.md

- Edited to include `kn` CLI as a pre-req
- pulled out Homebrew command 
- bolded important portions of the page
- conformed "Serving" and "Eventing" to the  [Knative Word and Phrase List](https://docs.google.com/spreadsheets/d/1p1_kBUd6ZvonxHkMcEJPayf6QIpExuFf5cFq0ptar7I/edit#gid=0) 
- Added link to Private Registry documentation

* Update install-serving-with-yaml.md

- removed reference to KN CLI (now in Pre-Reqs) 
- trimmed the fat around Installing Kantive Eventing
- Added relevant context to optional extensions

* Update install-serving-with-yaml.md

Added same context from Eventing Page

* Update install-serving-with-yaml.md

Added same context from Eventing Page, added (like TLS) to second bullet.

* Update install-eventing-with-yaml.md

Removed reference to KN CLI (now in Pre-Reqs)

* Update install-serving-with-yaml.md

added reference to install files

* Update install-extensions.md

Fix broken link

* Create install-extensions.md

Fix broken link

* Update install-eventing-with-yaml.md

* Update prerequisites.md

made wording less bad

* Make Homebrew installation the first option for `kn`, pull command to install out of Github and into knative.dev site (#3410)

* Update install-kn.md

Adding brew install kn command directly to page and making it the first option

* Update docs/client/install-kn.md

Co-authored-by: Mike Petersen <mpetason@gmail.com>

Co-authored-by: Mike Petersen <mpetason@gmail.com>

* Create prerequisites.md (#3413)

whitespace fix

* Update prerequisites.md (#3414)

more whitespace

* remove (like TLS)

* Update install-serving-with-yaml.md (#3420)

Adding `kn` CLI to Next Steps

* Update install-eventing-with-yaml.md (#3421)

* Removing `kn` from required (#3424)

* Adding @snneji changes (#3429)

* Update install-serving-with-yaml.md (#3435)

accidentally left this out

* Adding @snneji changes round 2 (#3439)

* Adding @snneji changes

* Adding @snneji changes round 2

Co-authored-by: Mike Petersen <mpetason@gmail.com>
knative-prow-robot pushed a commit to knative-prow-robot/docs that referenced this pull request Apr 8, 2021
knative-prow-robot added a commit that referenced this pull request Apr 21, 2021
…sired prototype in UX/11 (#3440)

* Update _index.md

Changing link on the install page to link to pre-requisites

* Update prerequisites.md

Added links to install either Serving or Eventing in Pre-Req

* Update prerequisites.md

- Edited to include `kn` CLI as a pre-req
- pulled out Homebrew command
- bolded important portions of the page
- conformed "Serving" and "Eventing" to the  [Knative Word and Phrase List](https://docs.google.com/spreadsheets/d/1p1_kBUd6ZvonxHkMcEJPayf6QIpExuFf5cFq0ptar7I/edit#gid=0)
- Added link to Private Registry documentation

* Update install-serving-with-yaml.md

- removed reference to KN CLI (now in Pre-Reqs)
- trimmed the fat around Installing Kantive Eventing
- Added relevant context to optional extensions

* Update install-serving-with-yaml.md

Added same context from Eventing Page

* Update install-serving-with-yaml.md

Added same context from Eventing Page, added (like TLS) to second bullet.

* Update install-eventing-with-yaml.md

Removed reference to KN CLI (now in Pre-Reqs)

* Update install-serving-with-yaml.md

added reference to install files

* Update install-extensions.md

Fix broken link

* Update install-eventing-with-yaml.md

* Update prerequisites.md

made wording less bad

* Make Homebrew installation the first option for `kn`, pull command to install out of Github and into knative.dev site (#3410)

* Update install-kn.md

Adding brew install kn command directly to page and making it the first option

* Update docs/client/install-kn.md

Co-authored-by: Mike Petersen <mpetason@gmail.com>

Co-authored-by: Mike Petersen <mpetason@gmail.com>

* Create prerequisites.md (#3413)

whitespace fix

* Update prerequisites.md (#3414)

more whitespace

* remove (like TLS)

* Update install-serving-with-yaml.md (#3420)

Adding `kn` CLI to Next Steps

* Update install-eventing-with-yaml.md (#3421)

* Removing `kn` from required (#3424)

* Adding @snneji changes (#3429)

* Update install-serving-with-yaml.md (#3435)

accidentally left this out

* Adding @snneji changes round 2 (#3439)

* Adding @snneji changes

* Adding @snneji changes round 2

* Update install-kn.md

fix to homebrew statement

* Update docs/install/_index.md

* Update install-serving-with-yaml.md

* Update install-eventing-with-yaml.md

* Update install-serving-with-yaml.md

* Update install-extensions.md

* Update docs/client/install-kn.md

* Update docs/client/install-kn.md

* Update install-kn.md

* Update docs/install/install-serving-with-yaml.md

* Update install-kn.md

adding line

Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Mike Petersen <mpetason@gmail.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants