Mkdocs styles and home refactor + navigation menu nav items fixes #3564
Mkdocs styles and home refactor + navigation menu nav items fixes #3564gabo1208 wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
looks awesome - thanks! Think you'll need to rebase on #3558 though to pick up the little extra css there for the blog and community links. (btw having stuff under the header instead of content was actually intentional to try to make the header feel like one larger continuous block on the homepage, but with the new animated gradient we already moved away from that anyway so this seems reasonable to me; either way the reorg of the css is nice) |
|
.. hah, I just realised #3558 didnt actually merge yet, so I guess whichever lands last will have to rebase! :D |
|
Yeeeh XD was waiting for the merge @julz but feel free to merge this first :p |
|
.. looks like it was gradient that changed that 🤷 anyway no big deal I think let's hold off on this until #3558 lands if only so you can fix up my crappy css to be in the right place etc, if that's ok? :D |
|
Was the gradient PR, i just reorganized those styles to the separated files and integrated them with the new home html layout |
|
(yeah the gradient is sick!) |
|
Sure! Lets wait for #3558 then 👍🏼 |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
2 similar comments
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent |
|
@googlebot I consent |
* initial move over * Fix up index page names * Add version variables * Escape macro syntax * Automatic fixups with mkhugo * Drop no-longer-needed excludes * Rename more _index files * Move broker-configmaps.md a README.md avoids a directory with no index/readme * Autogenerate Eventing nav * Fix markdown * Update Serving nav * Add h1 headers Makes things look nicer in github, and makes search work more accurately in mkdocs * Unexclude all samples * Correct client link * Fix gitignore, skip hugo tests background gradient animation for homepage banner (#3556) Signed-off-by: Fabian Lopez <lfabian@vmware.com> add gh-action to deploy mkdocs to gh-pages (#3557) * add gh-action to deploy mkdocs to gh-pages * update commit user for gh-pages Signed-off-by: Carlos Santana <csantana23@gmail.com> * switch to fast livereload Signed-off-by: Carlos Santana <csantana23@gmail.com> Build blog and community with hugo (#3558) * Build blog and community with hugo * Use http-server instead of serve * Add package.json and ignore temp change name for menu item for preview (#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> Added detail per issue #3425 (#3514) Move mkdocs work over from julz/mkdocs branch (#3551) * initial move over * Fix up index page names * Add version variables * Escape macro syntax * Automatic fixups with mkhugo * Drop no-longer-needed excludes * Rename more _index files * Move broker-configmaps.md a README.md avoids a directory with no index/readme * Autogenerate Eventing nav * Fix markdown * Update Serving nav * Add h1 headers Makes things look nicer in github, and makes search work more accurately in mkdocs * Unexclude all samples * Correct client link * Fix gitignore, skip hugo tests background gradient animation for homepage banner (#3556) Signed-off-by: Fabian Lopez <lfabian@vmware.com> feat: improved assets and home organization, added some responsiveness to new home banner fix: fixed banned image width on mobile resolutions feat: improved assets and home organization, added some responsiveness to new home banner fix: removed unused styles link fix: fixing rebase errors
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@gabo1208: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gabo1208: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Too much troubles with the rebase |

Fixes #3561, #3548
Proposed Changes
this re-enables some theme features like the back to top button, fixed header (with shadow)
and scrolling events detection on the landing (home) page
You can view the results of this PR here