Skip to content

Mkdocs styles and home refactor + navigation menu nav items fixes #3564

Closed
gabo1208 wants to merge 2 commits into
knative:mkdocsfrom
gabo1208:mkdocs
Closed

Mkdocs styles and home refactor + navigation menu nav items fixes #3564
gabo1208 wants to merge 2 commits into
knative:mkdocsfrom
gabo1208:mkdocs

Conversation

@gabo1208
Copy link
Copy Markdown
Member

@gabo1208 gabo1208 commented May 12, 2021

Fixes #3561, #3548

Proposed Changes

  • Better organization of the css (take them out of the templates html
  • Removed all home content from the navs section to the content section
    this re-enables some theme features like the back to top button, fixed header (with shadow)
    and scrolling events detection on the landing (home) page

You can view the results of this PR here

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rhuss after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhuss in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 12, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no Indicates the PR's author has not signed the CLA. cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels May 12, 2021
@julz
Copy link
Copy Markdown
Contributor

julz commented May 12, 2021

looks awesome - thanks! Think you'll need to rebase on #3558 though to pick up the little extra css there for the blog and community links.

(btw having stuff under the header instead of content was actually intentional to try to make the header feel like one larger continuous block on the homepage, but with the new animated gradient we already moved away from that anyway so this seems reasonable to me; either way the reorg of the css is nice)

@julz
Copy link
Copy Markdown
Contributor

julz commented May 12, 2021

.. hah, I just realised #3558 didnt actually merge yet, so I guess whichever lands last will have to rebase! :D

@gabo1208
Copy link
Copy Markdown
Member Author

gabo1208 commented May 12, 2021

Yeeeh XD was waiting for the merge @julz but feel free to merge this first :p

@julz
Copy link
Copy Markdown
Contributor

julz commented May 12, 2021

was it this PR that made the top block bigger or was it the gradient PR? Im not sure I personally like the header being quite this big (Im not a designer, tho!):

image

@julz
Copy link
Copy Markdown
Contributor

julz commented May 12, 2021

.. looks like it was gradient that changed that 🤷 anyway no big deal

I think let's hold off on this until #3558 lands if only so you can fix up my crappy css to be in the right place etc, if that's ok? :D

@gabo1208
Copy link
Copy Markdown
Member Author

gabo1208 commented May 12, 2021

Was the gradient PR, i just reorganized those styles to the separated files and integrated them with the new home html layout
But yeah! The banner looks kinda cool and more interesting now

@julz
Copy link
Copy Markdown
Contributor

julz commented May 12, 2021

(yeah the gradient is sick!)

@gabo1208
Copy link
Copy Markdown
Member Author

Sure! Lets wait for #3558 then 👍🏼

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels May 12, 2021
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@gabo1208
Copy link
Copy Markdown
Member Author

@googlebot I consent.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

2 similar comments
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@julz
Copy link
Copy Markdown
Contributor

julz commented May 12, 2021

@googlebot I consent

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@leetcope
Copy link
Copy Markdown
Contributor

@googlebot I consent

@gabo1208
Copy link
Copy Markdown
Member Author

@googlebot I consent

julz and others added 2 commits May 12, 2021 18:37
* initial move over

* Fix up index page names

* Add version variables

* Escape macro syntax

* Automatic fixups with mkhugo

* Drop no-longer-needed excludes

* Rename more _index files

* Move broker-configmaps.md a README.md

avoids a directory with no index/readme

* Autogenerate Eventing nav

* Fix markdown

* Update Serving nav

* Add h1 headers

Makes things look nicer in github, and makes search work more accurately
in mkdocs

* Unexclude all samples

* Correct client link

* Fix gitignore, skip hugo tests

background gradient animation for homepage banner (#3556)

Signed-off-by: Fabian Lopez <lfabian@vmware.com>

add gh-action to deploy mkdocs to gh-pages (#3557)

* add gh-action to deploy mkdocs to gh-pages

* update commit user for gh-pages

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* switch to fast livereload

Signed-off-by: Carlos Santana <csantana23@gmail.com>

Build blog and community with hugo (#3558)

* Build blog and community with hugo

* Use http-server instead of serve

* Add package.json and ignore temp

change name for menu item for preview (#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

Added detail per issue #3425 (#3514)

Move mkdocs work over from julz/mkdocs branch (#3551)

* initial move over

* Fix up index page names

* Add version variables

* Escape macro syntax

* Automatic fixups with mkhugo

* Drop no-longer-needed excludes

* Rename more _index files

* Move broker-configmaps.md a README.md

avoids a directory with no index/readme

* Autogenerate Eventing nav

* Fix markdown

* Update Serving nav

* Add h1 headers

Makes things look nicer in github, and makes search work more accurately
in mkdocs

* Unexclude all samples

* Correct client link

* Fix gitignore, skip hugo tests

background gradient animation for homepage banner (#3556)

Signed-off-by: Fabian Lopez <lfabian@vmware.com>

feat: improved assets and home organization, added some responsiveness to new home banner

fix: fixed banned image width on mobile resolutions

feat: improved assets and home organization, added some responsiveness to new home banner

fix: removed unused styles link

fix: fixing rebase errors
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 12, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@gabo1208: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-cla google-cla Bot removed the cla: no Indicates the PR's author has not signed the CLA. label May 12, 2021
@knative-prow-robot knative-prow-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 12, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label May 12, 2021
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 12, 2021
@gabo1208 gabo1208 closed this May 12, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@gabo1208: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-docs-go-coverage 016e3a9 link /test pull-knative-docs-go-coverage
pull-knative-docs-integration-tests 016e3a9 link /test pull-knative-docs-integration-tests
pull-knative-docs-build-tests 016e3a9 link /test pull-knative-docs-build-tests
pull-knative-docs-unit-tests 016e3a9 link /test pull-knative-docs-unit-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabo1208 gabo1208 deleted the mkdocs branch May 12, 2021 23:39
@gabo1208
Copy link
Copy Markdown
Member Author

Too much troubles with the rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. kind/mkdocs needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants