Revert changes to community#3757
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
✔️ Deploy Preview for dev-knative ready! 🔨 Explore the source changes: 97d6a69 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60c0816f51f8f0000781b6f3 😎 Browse the preview: https://deploy-preview-3757--dev-knative.netlify.app |
|
Can you do a find and replace for shell -> bash? |
Do we care about applying these rules to community? Couldn't we/shouldn't we leave that folder till after GA when we fix up community to use mkdocs? Either way, if we do want to do that again I'd suggest we re-apply it in a different PR so each PR does one thing as much as possible: having PRs making lots of unrelated changes made this a bit harder to track down via git bisect than it needed to be |
|
Sorry, I wasn't clear, it was already fixed but this PR changes it back to shell, so it's a regressive change |
|
/hold |
|
@julz I will leave it up to you just in case you did understand my first message as I meant it! |
|
I personally think we should probably just leave community/ alone for now, but if it was intentional to fix shell->bash there as well as elsewhere I'm happy to do that conversion again in a follow-on PR once this lands. (It took longer than it should have to track this bug down, and it was harder to revert cleanly and safely, because the commit that introduced the problem made lots of changes at once, so I'd like to avoid repeating that in the fix iyswim). /unhold |
|
as soon as this merges Ill do a follow-on to s/shell/bash/ in community, and we can double check that all looks right with hugo (I assume it does, but since the broader change this came in with actually broke community and we didn't realise, we should check!) |
This commit reverts changes made to community which assumed it was being built by mkdocs (since it's still built with hugo) and caused formatting to break in the community tab.
/assign @omerbensaadon I did a straight
git checkout HEAD~10 community/so please check I didn't revert something we actually wanted here, but it looks right to me