Skip to content

Use bash rather than shell code blocks in community#3761

Merged
knative-prow-robot merged 2 commits into
knative:mkdocsfrom
julz:bashshellshellbash
Jun 9, 2021
Merged

Use bash rather than shell code blocks in community#3761
knative-prow-robot merged 2 commits into
knative:mkdocsfrom
julz:bashshellshellbash

Conversation

@julz
Copy link
Copy Markdown
Contributor

@julz julz commented Jun 9, 2021

See conversation in #3757.

/hold to make sure the preview looks good before merging this

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 9, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 9, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 9, 2021 •
edited
Loading

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: bc74c35

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60c0e2aa9dddaa00072ad225

😎 Browse the preview: https://deploy-preview-3761--dev-knative.netlify.app/community/samples/serving/machinelearning-python-bentoml

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@julz
Copy link
Copy Markdown
Contributor Author

julz commented Jun 9, 2021 •
edited
Loading

Thought for a minute that this broke on the bentoml page, but looks like that's actually broken on the old site too: https://knative.dev/community/samples/serving/machinelearning-python-bentoml/

Created #3762

@julz
Copy link
Copy Markdown
Contributor Author

julz commented Jun 9, 2021

/unhold
/assign @omerbensaadon

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@omerbensaadon
Copy link
Copy Markdown

omerbensaadon commented Jun 9, 2021

/lgtm
/approve

Thanks Julz :D

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, julz, omerbensaadon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d189f7e into knative:mkdocs Jun 9, 2021
RichardJJG pushed a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
@julz @RichardJJG
Use bash rather than shell code blocks in community (knative#3761)
f7042fa 
* Use bash rather than shell code blocks in community

* Missed a spot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gabo1208 gabo1208 gabo1208 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gabo1208 gabo1208

@omerbensaadon omerbensaadon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@julz @omerbensaadon @knative-prow-robot @gabo1208