fixing broken links by psschwei · Pull Request #4014 · knative/docs

psschwei · 2021-07-14T21:43:00Z

Fixes #4013

Proposed Changes

Fixes broken links on docs/serving/knative-kubernetes-services.md page
(note that the first link here was circular... I assume it was meant to point to the readme)
Fixes broken links in DEVELOPMENT.md

netlify · 2021-07-14T21:43:05Z

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: e5c3601

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/60fb1c33bbef700007648737

😎 Browse the preview: https://deploy-preview-4014--knative.netlify.app/development/reference/api/serving-api

abrennan89

/lgtm

abrennan89 · 2021-07-16T17:12:06Z

/hold

abrennan89 · 2021-07-16T17:12:30Z

@psschwei this looks like it needs a rebase, also, does this need to be cherrypicked to 0.24 as well?

psschwei · 2021-07-16T17:44:57Z

Yes, this should be cherrypicked to 0.24, as the links are broken there as well

Will rebase shortly.

psschwei · 2021-07-16T17:54:08Z

/hold

psschwei · 2021-07-16T18:04:56Z

@abrennan89 I think the last two links (to website / maintainer help) on DEVELOPMENT.md have been sunset, maybe as part of #4020 or #4024 . I wonder if it would be better for it to mirror the changes @RichardJJG made to blog/README.md?

abrennan89 · 2021-07-16T20:03:44Z

Assigning @RichardJJG to take a look - might be better to rebase once any of his PRs are merged?
@psschwei if this is undoing any of Richard's changes I'd just re-add whatever he did.

psschwei · 2021-07-16T20:28:04Z

@psschwei if this is undoing any of Richard's changes I'd just re-add whatever he did.

Not undoing any changes, at least I don't think it is. I think basically what's happening is:

previously, the DEVELOPMENT.md doc and the blog/README.md doc were exactly the same
in Moved and added links #4024, the blog/README.md doc was truncated to a single, main link, but DEVELOPMENT.md was not changed (edit: looks like there was a typo in the main link, I made a commit to fix and updated the link here)
my question was whether the DEVELOPMENT.md doc should also be truncated to the single main link to the "contributing to knative docs" documentation, like the new blog/README.md?

abrennan89 · 2021-07-22T21:11:01Z

cc @omerbensaadon @RichardJJG to answer the comments / questions on this one please

omerbensaadon · 2021-07-23T19:24:49Z

@psschwei it might be easier to revert changes to the DEVELOPMENT.md file and just ship the fix the linked issue is targeting

omerbensaadon

I think if you remove this it should be good to merge? If you don't have any conflicts with Richard's changes, I'd /unhold.

If you do, I'd take @RichardJJG's changes where there are conflicts.

omerbensaadon · 2021-07-23T19:25:37Z

+   * [Website help](https://knative.dev/docs/help/contributor/publishing)
+   * [Maintainer help](https://knative.dev/docs/help/maintainer/)


These pages don't exist anymore

Suggested change

* [Website help](https://knative.dev/docs/help/contributor/publishing)

* [Maintainer help](https://knative.dev/docs/help/maintainer/)

psschwei · 2021-07-23T19:35:16Z

It looks like #4054 also fixes the original broken links (and in a better way than my PR), so happy to close this one and let the other one merge instead.

(And apologies to @snneji for forgetting to assign the issue)

omerbensaadon · 2021-07-23T19:37:23Z

I think your PR still does fix some broken links in Development.MD as well as the blog README

omerbensaadon · 2021-07-23T19:38:04Z

If you can

Remove the last two lines from my review
Remove changes covered by Fix broken links #4054

We can get this merged

RichardJJG · 2021-07-26T11:22:56Z

/lgtm

RichardJJG · 2021-07-26T13:46:17Z

/approve

psschwei · 2021-07-26T13:57:20Z

/hold

Looks like both @abrennan89 and I put holds on this... I'm good to remove mine.

abrennan89

/lgtm
/unhold

knative-prow-robot · 2021-07-26T13:58:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, psschwei, RichardJJG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [abrennan89]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This reverts commit 4771c4e.

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 14, 2021

knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2021

abrennan89 approved these changes Jul 16, 2021

View reviewed changes

knative-prow-robot assigned abrennan89 Jul 16, 2021

knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 16, 2021

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2021

psschwei force-pushed the link-fix branch from e9c9a52 to 646cb93 Compare July 16, 2021 17:52

knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 16, 2021

abrennan89 requested a review from RichardJJG July 16, 2021 20:03

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2021

psschwei added 3 commits July 22, 2021 16:24

fixing broken links

f976db3

updating link to help docs

2a0a3f3

capitalizing README in link

db43116

psschwei force-pushed the link-fix branch from 495bd5e to db43116 Compare July 22, 2021 20:32

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2021

abrennan89 removed their assignment Jul 22, 2021

abrennan89 requested review from omerbensaadon and snneji July 22, 2021 21:11

omerbensaadon suggested changes Jul 23, 2021

View reviewed changes

knative-prow-robot assigned omerbensaadon Jul 23, 2021

updates from review

e5c3601

knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2021

knative-prow-robot assigned RichardJJG Jul 26, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2021

abrennan89 approved these changes Jul 26, 2021

View reviewed changes

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2021

knative-prow-robot assigned abrennan89 Jul 26, 2021

knative-prow-robot merged commit 4771c4e into knative:mkdocs Jul 26, 2021

RichardJJG added a commit to RichardJJG/docs that referenced this pull request Jul 27, 2021

Revert "fixing broken links (knative#4014)"

65dae72

This reverts commit 4771c4e.

psschwei deleted the link-fix branch November 4, 2021 15:07

		* [Website help](https://knative.dev/docs/help/contributor/publishing)
		* [Maintainer help](https://knative.dev/docs/help/maintainer/)

Conversation

psschwei commented Jul 14, 2021

Proposed Changes

Uh oh!

netlify Bot commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abrennan89 left a comment

Choose a reason for hiding this comment

Uh oh!

abrennan89 commented Jul 16, 2021

Uh oh!

abrennan89 commented Jul 16, 2021

Uh oh!

psschwei commented Jul 16, 2021

Uh oh!

psschwei commented Jul 16, 2021

Uh oh!

psschwei commented Jul 16, 2021

Uh oh!

abrennan89 commented Jul 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psschwei commented Jul 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abrennan89 commented Jul 22, 2021

Uh oh!

omerbensaadon commented Jul 23, 2021

Uh oh!

omerbensaadon left a comment

Choose a reason for hiding this comment

Uh oh!

omerbensaadon Jul 23, 2021

Choose a reason for hiding this comment

Uh oh!

psschwei commented Jul 23, 2021

Uh oh!

omerbensaadon commented Jul 23, 2021

Uh oh!

omerbensaadon commented Jul 23, 2021

Uh oh!

RichardJJG commented Jul 26, 2021

Uh oh!

RichardJJG commented Jul 26, 2021

Uh oh!

psschwei commented Jul 26, 2021

Uh oh!

abrennan89 left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Jul 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify Bot commented Jul 14, 2021 •

edited

Loading

abrennan89 commented Jul 16, 2021 •

edited

Loading

psschwei commented Jul 16, 2021 •

edited

Loading