Skip to content

Salvage old contributor docs#4020

Merged
knative-prow-robot merged 18 commits into
knative:mkdocsfrom
RichardJJG:4003
Jul 16, 2021
Merged

Salvage old contributor docs#4020
knative-prow-robot merged 18 commits into
knative:mkdocsfrom
RichardJJG:4003

Conversation

@RichardJJG
Copy link
Copy Markdown
Contributor

@RichardJJG RichardJJG commented Jul 15, 2021

Fixes #4003

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 15, 2021
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 15, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 15, 2021 •
edited
Loading

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: ec1192a

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/60f15f4c50bc2d0008da5c48

😎 Browse the preview: https://deploy-preview-4020--knative.netlify.app

julz
julz reviewed Jul 15, 2021
View reviewed changes
Comment thread docs/help/contributor/github.md
@RichardJJG RichardJJG changed the title Culled old contributor docs Cull old contributor docs Jul 15, 2021
@RichardJJG RichardJJG changed the title Cull old contributor docs Salvage old contributor docs Jul 15, 2021
abrennan89
abrennan89 reviewed Jul 15, 2021
View reviewed changes
Comment thread docs/help/contributor/creating-blog-posts.md Outdated
abrennan89
abrennan89 reviewed Jul 15, 2021
View reviewed changes
Comment thread docs/help/contributor/creating-blog-posts.md Outdated
abrennan89
abrennan89 reviewed Jul 15, 2021
View reviewed changes
Comment thread docs/help/contributor/creating-new-docs.md Outdated
abrennan89
abrennan89 reviewed Jul 15, 2021
View reviewed changes
Comment thread docs/help/contributor/creating-new-docs.md Outdated
abrennan89
abrennan89 reviewed Jul 15, 2021
View reviewed changes
Comment thread docs/help/contributor/creating-new-docs.md Outdated
abrennan89
abrennan89 reviewed Jul 15, 2021
View reviewed changes
Comment thread docs/help/contributor/creating-new-docs.md Outdated
abrennan89
abrennan89 reviewed Jul 15, 2021
View reviewed changes
Comment thread docs/help/contributor/creating-new-docs.md Outdated
abrennan89
abrennan89 suggested changes Jul 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments / suggestions

@abrennan89 abrennan89 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. labels Jul 15, 2021
RichardJJG and others added 2 commits July 16, 2021 08:40
@RichardJJG @abrennan89
Update docs/help/contributor/creating-new-docs.md
8153fcc 
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
@RichardJJG @abrennan89
Update docs/help/contributor/creating-new-docs.md
c9df8c6 
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
@RichardJJG
Copy link
Copy Markdown
Contributor Author

RichardJJG commented Jul 16, 2021

All suggestions acted on, thanks, @abrennan89. I moved the templates to docs/help/contributor/templates -- it makes more sense for them to live there than cluttering up the top level.

abrennan89
abrennan89 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @RichardJJG ! 🙂
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, RichardJJG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@knative-prow-robot knative-prow-robot merged commit 21fe8c7 into knative:mkdocs Jul 16, 2021
@RichardJJG RichardJJG deleted the 4003 branch July 16, 2021 12:57
@psschwei psschwei mentioned this pull request Jul 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@julz julz julz left review comments

@abrennan89 abrennan89 abrennan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abrennan89 abrennan89

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Salvage content from old contributor docs

4 participants

@RichardJJG @knative-prow-robot @julz @abrennan89