Skip to content

Add SASL for KafkaSource docs#5230

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
abrennan89:kafkaSASL
Sep 23, 2022
Merged

Add SASL for KafkaSource docs#5230
knative-prow[bot] merged 1 commit into
knative:mainfrom
abrennan89:kafkaSASL

Conversation

@abrennan89
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 commented Sep 22, 2022

Fixes #3583

  • Added SASL docs
  • Moved "clean up" to end of section (source deletion should be after all the other options)

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 22, 2022 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6a5448d
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/632c93e6ac703b00099bbf4b
😎 Deploy Preview https://deploy-preview-5230--knative.netlify.app/docs/eventing/sources/kafka-source
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 22, 2022
@abrennan89
Copy link
Copy Markdown
Contributor Author

abrennan89 commented Sep 22, 2022

/retest

pierDipi
pierDipi approved these changes Sep 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Sep 23, 2022

Thanks!

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Sep 23, 2022

GH actions failures seem unrelated

@knative-prow knative-prow Bot merged commit eede7c5 into knative:main Sep 23, 2022
@abrennan89
Copy link
Copy Markdown
Contributor Author

abrennan89 commented Sep 23, 2022

@pierDipi it seems like it broke the page merging this https://knative.dev/development/eventing/sources/kafka-source/ 😖

@psschwei psschwei mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew Awaiting requested review from matzew

1 more reviewer

@pierDipi pierDipi pierDipi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pierDipi pierDipi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Describe SASL option for KafkaSource

2 participants

@abrennan89 @pierDipi