Skip to content

Fix markdown rendering issue with brackets#5244

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
psschwei:fix-brackets
Sep 23, 2022
Merged

Fix markdown rendering issue with brackets#5244
knative-prow[bot] merged 1 commit into
knative:mainfrom
psschwei:fix-brackets

Conversation

@psschwei
Copy link
Copy Markdown
Member

@psschwei psschwei commented Sep 23, 2022

xref #5230
/assign @abrennan89

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 23, 2022 •
edited
Loading

✅ Deploy Preview for knative ready!

Name Link
🔨 Latest commit 50794cd
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/632def529bcf90000897cba2
😎 Deploy Preview https://deploy-preview-5244--knative.netlify.app/docs/eventing/sources/kafka-source
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2022
@psschwei
Copy link
Copy Markdown
Member Author

psschwei commented Sep 23, 2022

check the preview to make sure 😄

@psschwei
Copy link
Copy Markdown
Member Author

psschwei commented Sep 23, 2022

doesn't actually fix the issue
/hold

@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@abrennan89
Copy link
Copy Markdown
Contributor

abrennan89 commented Sep 23, 2022

Looks like it fixes it OK?
/lgtm
/approve

The build check I guess is still failing and unrelated, but at least this fixes that one page

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@psschwei
Copy link
Copy Markdown
Member Author

psschwei commented Sep 23, 2022

/hold cancel

@knative-prow knative-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@psschwei
Copy link
Copy Markdown
Member Author

psschwei commented Sep 23, 2022 •
edited
Loading

Looks like it fixes it OK?

first fix showed the backslashes, new one uses {% raw %} jinja tags so that macros plugin will ignore the {{ stuff }} blocks

@abrennan89
Copy link
Copy Markdown
Contributor

abrennan89 commented Sep 23, 2022

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@knative-prow knative-prow Bot merged commit 36ff4ae into knative:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@abrennan89 abrennan89

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psschwei @abrennan89