Migrate Eventing Sources to use CloudEvent Client by n3wscott · Pull Request #191 · knative/eventing-contrib

n3wscott · 2019-01-29T18:39:18Z

Proposed Changes

Updates all sources to use cloudevents.Client
Had to fix up some tests to make this work.

Release Note

Sources now use `cloudevents.Client`, a simpler way to send CloudEvents.

n3wscott · 2019-01-29T18:41:54Z

/cc @Harwayne
/cc @whynowy
/cc @vaikas-google
/cc @greghaynes

knative-prow-robot · 2019-01-29T18:41:57Z

@n3wscott: GitHub didn't allow me to request PR reviews from the following users: whynowy.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @Harwayne
/cc @whynowy
/cc @vaikas-google
/cc @greghaynes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

n3wscott · 2019-01-29T18:43:36Z

/hold

Missed contrib/gcppubsub. I will do that now.

n3wscott · 2019-01-29T18:53:02Z

/hold cancel

n3wscott · 2019-01-29T21:06:11Z

/retest

n3wscott · 2019-01-29T21:18:07Z

/test pull-knative-eventing-sources-go-coverage

n3wscott · 2019-01-30T18:36:36Z

/test pull-knative-eventing-sources-unit-tests

n3wscott · 2019-01-30T18:38:32Z

go test -race -v ./cmd/... ./pkg/... ./contrib/... works locally... come on prow.

n3wscott · 2019-01-30T19:02:39Z

Hm, I had an old version of go installed...

⦿ go version
go version go1.10.3 darwin/amd64

Updating...

OK, updating to 1.11 showed me the problem.

vaikas · 2019-01-30T19:45:10Z

I don't think this was the failure, but concerning regardless. I0130 19:37:20.877] ================== I0130 19:37:20.878] WARNING: DATA RACE I0130 19:37:20.878] Write at 0x00c000030088 by goroutine 8: I0130 19:37:20.887] github.com/knative/eventing-sources/pkg/adapter/cronjobevents.TestStart_ServeHTTP() I0130 19:37:20.887] /go/src/github.com/knative/eventing-sources/pkg/adapter/cronjobevents/adapter_test.go:53 +0x3ff I0130 19:37:20.887] testing.tRunner() I0130 19:37:20.887] /usr/local/go/src/testing/testing.go:827 +0x162 I0130 19:37:20.888] I0130 19:37:20.889] Previous read at 0x00c000030088 by goroutine 11: I0130 19:37:20.889] github.com/knative/eventing-sources/pkg/adapter/cronjobevents.TestStart_ServeHTTP.func1.1() I0130 19:37:20.889] /go/src/github.com/knative/eventing-sources/pkg/adapter/cronjobevents/adapter_test.go:70 +0xad I0130 19:37:20.889] I0130 19:37:20.890] Goroutine 8 (running) created at: I0130 19:37:20.891] testing.(*T).Run() I0130 19:37:20.891] /usr/local/go/src/testing/testing.go:878 +0x659 I0130 19:37:20.891] testing.runTests.func1() I0130 19:37:20.891] /usr/local/go/src/testing/testing.go:1119 +0xa8 I0130 19:37:20.891] testing.tRunner() I0130 19:37:20.892] /usr/local/go/src/testing/testing.go:827 +0x162 I0130 19:37:20.893] testing.runTests() I0130 19:37:20.893] /usr/local/go/src/testing/testing.go:1117 +0x4ee I0130 19:37:20.893] testing.(*M).Run() I0130 19:37:20.893] /usr/local/go/src/testing/testing.go:1034 +0x2ee I0130 19:37:20.894] main.main() I0130 19:37:20.895] _testmain.go:46 +0x221 I0130 19:37:20.895] I0130 19:37:20.895] Goroutine 11 (finished) created at: I0130 19:37:20.895] github.com/knative/eventing-sources/pkg/adapter/cronjobevents.TestStart_ServeHTTP.func1() I0130 19:37:20.897] /go/src/github.com/knative/eventing-sources/pkg/adapter/cronjobevents/adapter_test.go:68 +0x2d0 I0130 19:37:20.897] testing.tRunner() I0130 19:37:20.897] /usr/local/go/src/testing/testing.go:827 +0x162

…

On Wed, Jan 30, 2019 at 11:38 AM Knative Prow Robot < ***@***.***> wrote: @n3wscott <https://github.com/n3wscott>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command pull-knative-eventing-sources-build-tests 8ed0e5a <8ed0e5a> link <https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_eventing-sources/191/pull-knative-eventing-sources-build-tests/1090693039019528192/> /test pull-knative-eventing-sources-build-tests pull-knative-eventing-sources-unit-tests ae17b77 <ae17b77> link <https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_eventing-sources/191/pull-knative-eventing-sources-unit-tests/1090695178940846081/> /test pull-knative-eventing-sources-unit-tests Full PR test history <https://gubernator.knative.dev/pr/knative_eventing-sources/191>. Your PR dashboard <https://gubernator.knative.dev/pr/n3wscott>. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#191 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKwedHHGw9Lvve_eeZjzf8W5b38YVALeks5vIfSkgaJpZM4aYrTm> .

knative-metrics-robot · 2019-01-30T20:13:00Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-sources-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/awssqs/adapter.go	54.2%	61.7%	7.5
pkg/adapter/cronjobevents/adapter.go	36.1%	100.0%	63.9
pkg/adapter/github/adapter.go	92.9%	97.6%	4.7
pkg/adapter/kubernetesevents/adapter.go	52.6%	74.2%	21.6

vaikas · 2019-01-30T21:02:19Z

/approve

knative-prow-robot · 2019-01-30T21:02:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vaikas · 2019-01-30T23:25:07Z

/lgtm

Scott Nichols added 2 commits January 29, 2019 10:21

refactored sources to use cloudevent client.

26c9a44

Final integration. tests passing.

d54f00e

knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 29, 2019

knative-prow-robot requested review from Harwayne and vaikas January 29, 2019 18:39

knative-prow-robot requested a review from greghaynes January 29, 2019 18:41

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2019

fixed the test.

7050553

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2019

Scott Nichols added 3 commits January 29, 2019 12:25

adding more tests to cron job source. because I am a sucker.

b3059ba

adding k8s source tests.

eaa984f

garbage tests for garbage rules.

41b060b

increase timeout time.

1dfd300

Scott Nichols added 2 commits January 29, 2019 13:20

not a real test.

a2b8262

Merge branch 'master' into use-cloudevent-client

6634c36

fix test failure on new version of go.

fd85dda

Scott Nichols added 2 commits January 30, 2019 11:27

added fake k8s client.

8ed0e5a

adding k8s fake client.

ae17b77

move bad cron out.

94a8720

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019

knative-prow-robot assigned vaikas Jan 30, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019

knative-prow-robot merged commit bffdae6 into knative:master Jan 30, 2019

This was referenced Feb 8, 2019

Another attempt to add an E2E test #178

Merged

Data race in cronjobevents #206

Closed

Conversation

n3wscott commented Jan 29, 2019

Proposed Changes

Uh oh!

n3wscott commented Jan 29, 2019

Uh oh!

knative-prow-robot commented Jan 29, 2019

Uh oh!

n3wscott commented Jan 29, 2019

Uh oh!

n3wscott commented Jan 29, 2019

Uh oh!

n3wscott commented Jan 29, 2019

Uh oh!

n3wscott commented Jan 29, 2019

Uh oh!

n3wscott commented Jan 30, 2019

Uh oh!

n3wscott commented Jan 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n3wscott commented Jan 30, 2019

Uh oh!

vaikas commented Jan 30, 2019 via email

Uh oh!

knative-metrics-robot commented Jan 30, 2019

Uh oh!

vaikas commented Jan 30, 2019

Uh oh!

knative-prow-robot commented Jan 30, 2019

Uh oh!

vaikas commented Jan 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

n3wscott commented Jan 30, 2019 •

edited

Loading