Another attempt to add an E2E test by bbrowning · Pull Request #178 · knative/eventing-contrib

bbrowning · 2019-01-11T22:33:44Z

This is an attempt to push #121 to completion so we get some basic E2E testing for eventing-sources. It may take a couple of iterations here to get things passing.

This is a copy of the eventing E2E test which checks if KubernetesEventSource can deliver an event to a sink.

Dep added a bunch of non-go vendored files from eventing/cmd/* for some reason.

This was fixed in Istio 1.0.

It isn't installed by default for e2e tests.

This copies over the k8sevents image, some other necessary utility classes, and updates the location the e2e tests look for images to the published eventing-sources image path.

Update the test import in k8s_events_test.go to eventing-sources/test instead of eventing/test. This fixes an error around duplicated e2e test flags and ensures we aren't reliant on implementation details of the eventing repo's tests.

bbrowning · 2019-01-12T12:34:22Z

/test pull-knative-eventing-sources-integration-tests

vaikas · 2019-01-17T20:38:27Z

@n3wscott since you just cleaned up eventing e2e tests.

n3wscott · 2019-01-25T18:35:00Z

It looks like there is a lot of copy/pasta from the e2e test from eventing. I think we can let this in at the moment but I think we (knative) should build up a e2e framework that can be shared between the project. What do you think of that overall plan?

So, let this in, but it is tech-debt.

bbrowning · 2019-02-08T13:14:32Z

There is definitely copy & paste here - both from the previous PR (121) and from Eventing repo in general. At the time, my goal was to just push the e2e work already started to a working state so that we'd get some e2e test coverage here.

I've resolved the merge conflicts here so it's unblocked from getting in. And I'll create an issue in knative/pkg to track pulling these common e2e test bits out. I believe other repos also have similar duplication of e2e helpers that would also benefit from consolidation.

bbrowning · 2019-02-08T15:51:29Z

@vaikas-google @n3wscott Note that the most recent unit tests run as part of this PR exposed the same data race observed on #191 - a lot of DATA RACE mentions at https://storage.googleapis.com/knative-prow/pr-logs/pull/knative_eventing-sources/178/pull-knative-eventing-sources-unit-tests/1093897152024809473/build-log.txt

bbrowning · 2019-02-08T16:01:38Z

/test pull-knative-eventing-sources-unit-tests

I missed then when catching up on the latest test-infra changes for this PR.

bbrowning · 2019-03-15T19:48:35Z

This initial e2e test is passing again and ready for an updated review. The expectation is that once we get an e2e suite bootstrapped others can start adding e2e tests for each source.

This is a full E2E test of the Kubernetes Events source wired up via Eventing. I know we've moved towards reducing test dependencies between repos in the other projects, but I left that dependency in for now as otherwise there's nowhere that confirms Eventing Sources and Eventing actually work together.

I believe the existing issue knative/pkg#26 is probably the best place to track reducing this kind of copy/paste between e2e setups in each repo and I added a comment there as well as this comment that will link the two issues.

srinivashegde86

we can use a few pkg/test methods here already

srinivashegde86 · 2019-03-15T22:37:12Z

+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/util/wait"
+
+	// Mysteriously required to support GCP auth (required by k8s libs).


I dont think we need this anymore

Serving and Eventing master still have this in as well. I can attempt to take it out and see what happens, but I assume something still needs it.

srinivashegde86 · 2019-03-18T17:13:11Z

/lgtm

grantr

Thanks @bbrowning for getting this across the line! The first one is the hardest.

These will probably need more work as we expand the number of Addressables (e.g. Broker) and write E2E tests for more sources, but good start as is.

knative-prow-robot · 2019-03-18T18:34:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbrowning, grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [grantr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bbrowning · 2019-03-18T21:25:46Z

Thanks for the reviews!

grantr and others added 14 commits November 20, 2018 10:28

Add E2E test

9f49885

This is a copy of the eventing E2E test which checks if KubernetesEventSource can deliver an event to a sink.

Update deps for E2E test

917c515

Dep added a bunch of non-go vendored files from eventing/cmd/* for some reason.

Use the default integration test helpers

2f69e25

Remove 20 second teardown sleep

6eb4996

This was fixed in Istio 1.0.

Correct go_test_e2e parameter

5c95136

Copy upload-test-images.sh from eventing

ac1f537

Fix a couple docs typos

ce5a8e3

don't wait for gcppubsub to go away

1207b22

It isn't installed by default for e2e tests.

Use pkgTest namespace name everywhere

cd5698c

Remove errant whitespace

fe855b6

Merge branch 'master' into e2e-test

0db33a7

Copied e2e tests from eventing also need k8sevents image

1007ce8

This copies over the k8sevents image, some other necessary utility classes, and updates the location the e2e tests look for images to the published eventing-sources image path.

Merge remote-tracking branch 'upstream/master' into sources-e2e-take-2

14bf461

Undo accidental reverting of knative#155

ea13a18

knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 11, 2019

knative-prow-robot requested review from Harwayne and grantr January 11, 2019 22:33

bbrowning mentioned this pull request Jan 11, 2019

Point tests to the latest nightly eventing-sources knative/eventing#719

Closed

bbrowning added 2 commits January 11, 2019 17:50

Missed a couple of needed test helper files

6bdb491

Remove the last reference to pkg eventing/test

1ad5e47

Update the test import in k8s_events_test.go to eventing-sources/test instead of eventing/test. This fixes an error around duplicated e2e test flags and ensures we aren't reliant on implementation details of the eventing repo's tests.

vaikas reviewed Jan 24, 2019

View reviewed changes

Comment thread test/crd.go Outdated

Comment thread test/e2e/e2e.go

Comment thread test/e2e/e2e.go

Comment thread test/e2e/k8s_events_test.go

Merge remote-tracking branch 'upstream/master' into sources-e2e-take-2

6974d1c

bbrowning added 2 commits February 8, 2019 09:09

Somehow I missed that the merge required updating codegen

330d81f

No longer a default.yaml but instead individual resources

8e9be93

Satisfy markdown linter's preference for ordered lists

038f941

vaikas reviewed Mar 14, 2019

View reviewed changes

Comment thread test/cleanup.go Outdated

bbrowning changed the title ~~Another attempt to add an E2E test~~ [WIP] Another attempt to add an E2E test Mar 15, 2019

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2019

bbrowning added 8 commits March 15, 2019 13:17

Update e2e-tests.sh to latest test-infra conventions

295f196

Cleanup a confusing comment in test/crd.go

1183235

Merge remote-tracking branch 'upstream/master' into sources-e2e-take-2

252ed76

Switch to cloudevents/sdk-go for e2e test

794cd4a

Source is not actually a string in cloudevents sdk-go

34504b4

A bit more DOCKER_REPO_OVERRIDE -> KO_DOCKER_REPO

324c71d

I missed then when catching up on the latest test-infra changes for this PR.

e2e images publish with basenames now

458469d

bbrowning changed the title ~~[WIP] Another attempt to add an E2E test~~ Another attempt to add an E2E test Mar 15, 2019

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2019

srinivashegde86 reviewed Mar 15, 2019

View reviewed changes

Comment thread test/clients.go Outdated

Comment thread test/cleanup.go Outdated

srinivashegde86 reviewed Mar 15, 2019

View reviewed changes

Comment thread test/e2e/e2e.go

srinivashegde86 reviewed Mar 15, 2019

View reviewed changes

srinivashegde86 mentioned this pull request Mar 15, 2019

Add some more common test componets in pkg/test/ knative/pkg#321

Merged

bbrowning added 2 commits March 18, 2019 09:21

Duplicate less code from knative/pkg/test

c0c45bb

Add missing copyright header to test/e2e/e2e.go

3c3d03e

knative-prow-robot assigned srinivashegde86 Mar 18, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2019

grantr approved these changes Mar 18, 2019

View reviewed changes

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2019

knative-prow-robot merged commit 53f911f into knative:master Mar 18, 2019

bbrowning deleted the sources-e2e-take-2 branch March 18, 2019 21:25

Conversation

bbrowning commented Jan 11, 2019

Uh oh!

bbrowning commented Jan 12, 2019

Uh oh!

vaikas commented Jan 17, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

n3wscott commented Jan 25, 2019

Uh oh!

bbrowning commented Feb 8, 2019

Uh oh!

bbrowning commented Feb 8, 2019

Uh oh!

bbrowning commented Feb 8, 2019

Uh oh!

Uh oh!

bbrowning commented Mar 15, 2019

Uh oh!

srinivashegde86 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

srinivashegde86 Mar 15, 2019

Choose a reason for hiding this comment

Uh oh!

bbrowning Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

srinivashegde86 commented Mar 18, 2019

Uh oh!

grantr left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Mar 18, 2019

Uh oh!

bbrowning commented Mar 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

srinivashegde86 left a comment •

edited

Loading