Skip to content

Add some more common test componets in pkg/test/#321

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
srinivashegde86:common
Mar 18, 2019
Merged

Add some more common test componets in pkg/test/#321
knative-prow-robot merged 1 commit into
knative:masterfrom
srinivashegde86:common

Conversation

@srinivashegde86
Copy link
Copy Markdown
Contributor

This PR adds:

  1. Export GetConfigMap method
  2. Create methods for working with k8s pods
  3. Create a new file crd.go that adds few methods to deal with crd's.
  4. Add DOCKER_REPO and TAG flags here as we need it in other repos.
  5. Add a few wait cheks for k8s pods

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 15, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srinivashegde86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2019
@srinivashegde86
Copy link
Copy Markdown
Contributor Author

/cc @bbrowning

@srinivashegde86
Copy link
Copy Markdown
Contributor Author

knative/eventing-contrib#178 was adding a few k8s specific details to the eventing-sources repo. These should be in the pkg/test repo instead as these are generic to k8s and can be re-used by others

@srinivashegde86
Copy link
Copy Markdown
Contributor Author

Part of #26

@jessiezcc
Copy link
Copy Markdown

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2019
@knative-prow-robot knative-prow-robot merged commit 46bd1f1 into knative:master Mar 18, 2019
@srinivashegde86 srinivashegde86 deleted the common branch March 27, 2019 23:00
chengjingtao pushed a commit to katanomi/knative-pkg that referenced this pull request Oct 22, 2024
Co-authored-by: jzli <jzli@alauda.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants