Skip to content

[BUG] V02TTLAttribute gets changed by http libraries #1444

@mikehelmick

Description

@mikehelmick

Describe the bug
In the broker, an http event sent with binary encoding is received with the V02TTLAttribute having the wrong casing.

knativebrokerttl is the current value, but net/textproto's canonical encoding function causes this to be received as Knativebrokerttl

https://github.com/golang/go/blob/master/src/net/textproto/reader.go#L575

This ultimately causes broker events to be dropped with the header mismatch.

the cloudevents go SDK seems to normalize the known attributes, but extensions aren't part of the type so their final casing comes from lower level libraries.

Expected behavior
event's don't get dropped

To Reproduce
Send event to default broker where event matches a trigger
observe event is dropped due to not having the TTL extension

Knative release version
0.6 + head

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions