Fix issue with broker dropping messages with "No TTL Seen"#1452
Merged
Conversation
knative-prow-robot
added
the
size/XS
Contributor
Author
|
/assign @evankanderson |
Contributor
Author
|
/retest |
Contributor
Author
|
/hold working through integration test failures. |
knative-prow-robot
added
the
do-not-merge/hold
knative-prow-robot
added
lgtm
Contributor
|
/retest |
Contributor
|
/test pull-knative-eventing-integration-tests |
n3wscott
reviewed
Jun 24, 2019
knative-prow-robot
added
size/S
Contributor
Author
|
/hold cancel I'll also work with @n3wscott on changed to the cloud events SDK to treat extensions as case insensitive. |
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
|
/assign @grantr Grant is also looking at this. |
Contributor
|
/lgtm |
Contributor
Author
|
/retest |
Contributor
|
Looks like you need to run |
cloudevents attributes should be handled. See cloudevents/spec#321 for context.
Contributor
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, grantr, mikehelmick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
grantr
pushed a commit
to grantr/eventing
that referenced
this pull request
Jun 25, 2019
) * Fix issue with broker dropping messages with "No TTL Seen" * Treat the broker TTL attribute as case insensitive, in line with how cloudevents attributes should be handled. See cloudevents/spec#321 for context. * Remove unnecessary test change.
grantr
pushed a commit
to grantr/eventing
that referenced
this pull request
Jun 25, 2019
* Fix issue with broker dropping messages with "No TTL Seen" * Treat the broker TTL attribute as case insensitive, in line with how cloudevents attributes should be handled. See cloudevents/spec#321 for context. * Remove unnecessary test change.
Merged
knative-prow-robot
pushed a commit
that referenced
this pull request
Jun 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1392
Fixes #1444
Proposed Changes
Change casing on constant due to the way go http libraries use canonical mime encoding for http headers, this causes issues with using binary encoding for CloudEvents.
Release Note