-
Notifications
You must be signed in to change notification settings - Fork 628
Rename Trigger condition Subscribed to SubscriptionReady #2735
Copy link
Copy link
Closed
Labels
area/apikind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.kind/good-first-issueDenotes an issue ready for a new contributor.Denotes an issue ready for a new contributor.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Metadata
Metadata
Assignees
Labels
area/apikind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.kind/good-first-issueDenotes an issue ready for a new contributor.Denotes an issue ready for a new contributor.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Describe the bug
The Subscribed condition name is confusing. From #2163:
Expected behavior
The condition name is clearly related to the Subscription object under the trigger (if one exists).
To Reproduce
https://github.com/knative/eventing/blob/master/pkg/apis/eventing/v1beta1/trigger_lifecycle.go#L34
Knative release version
0.13.0
Additional context
As recommended by #2163, rename it to SubscriptionReady in v1alpha1 and v1beta1.
/kind good-first-issue
/area api