Skip to content

Rename Trigger condition Subscribed to SubscriptionReady#2827

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:rename
Mar 25, 2020
Merged

Rename Trigger condition Subscribed to SubscriptionReady#2827
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:rename

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Mar 24, 2020

Fixes #2735

Proposed Changes

  • Rename Trigger condition Subscribed to SubscriptionReady

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 24, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 24, 2020

Welcome @MIBc! It looks like this is your first PR to knative/eventing 🎉

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 24, 2020

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 24, 2020
@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Mar 24, 2020

/assign grantr

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Mar 25, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2020
mattmoor
mattmoor reviewed Mar 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

Comment thread pkg/apis/eventing/v1alpha1/trigger_lifecycle_test.go Outdated
grantr
grantr approved these changes Mar 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MIBc!

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, MIBc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@knative-prow-robot knative-prow-robot merged commit 21d0945 into knative:master Mar 25, 2020
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@nachocano nachocano Awaiting requested review from nachocano

2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@grantr grantr grantr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grantr grantr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename Trigger condition Subscribed to SubscriptionReady

6 participants

@MIBc @knative-prow-robot @vaikas @grantr @mattmoor @googlebot