Skip to content

Rename Trigger condition Subscribed to SubscriptionReady #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Mar 25, 2020
Merged

Rename Trigger condition Subscribed to SubscriptionReady #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apis/eventing/v1alpha1/trigger_lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const (

TriggerConditionBroker apis.ConditionType = "BrokerReady"

TriggerConditionSubscribed apis.ConditionType = "Subscribed"
TriggerConditionSubscribed apis.ConditionType = "SubscriptionReady"

TriggerConditionDependency apis.ConditionType = "DependencyReady"

Expand Down
14 changes: 7 additions & 7 deletions pkg/apis/eventing/v1alpha1/trigger_lifecycle_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,10 @@ func TestTriggerInitializeConditions(t *testing.T) {
Type: TriggerConditionReady,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscribed,
Type: TriggerConditionSubscriberResolved,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscriberResolved,
Type: TriggerConditionSubscribed,
Status: corev1.ConditionUnknown,
},
},
Expand Down Expand Up @@ -174,10 +174,10 @@ func TestTriggerInitializeConditions(t *testing.T) {
Type: TriggerConditionReady,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscribed,
Type: TriggerConditionSubscriberResolved,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscriberResolved,
Type: TriggerConditionSubscribed,
Status: corev1.ConditionUnknown,
},
},
Expand All @@ -204,12 +204,12 @@ func TestTriggerInitializeConditions(t *testing.T) {
}, {
Type: TriggerConditionReady,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscribed,
Status: corev1.ConditionTrue,
}, {
Type: TriggerConditionSubscriberResolved,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscribed,
Status: corev1.ConditionTrue,
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/eventing/v1beta1/trigger_lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const (

TriggerConditionBroker apis.ConditionType = "BrokerReady"

TriggerConditionSubscribed apis.ConditionType = "Subscribed"
TriggerConditionSubscribed apis.ConditionType = "SubscriptionReady"

TriggerConditionDependency apis.ConditionType = "DependencyReady"

Expand Down
14 changes: 7 additions & 7 deletions pkg/apis/eventing/v1beta1/trigger_lifecycle_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,10 @@ func TestTriggerInitializeConditions(t *testing.T) {
Type: TriggerConditionReady,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscribed,
Type: TriggerConditionSubscriberResolved,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscriberResolved,
Type: TriggerConditionSubscribed,
Status: corev1.ConditionUnknown,
},
},
Expand Down Expand Up @@ -178,10 +178,10 @@ func TestTriggerInitializeConditions(t *testing.T) {
Type: TriggerConditionReady,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscribed,
Type: TriggerConditionSubscriberResolved,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscriberResolved,
Type: TriggerConditionSubscribed,
Status: corev1.ConditionUnknown,
},
},
Expand All @@ -208,12 +208,12 @@ func TestTriggerInitializeConditions(t *testing.T) {
}, {
Type: TriggerConditionReady,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscribed,
Status: corev1.ConditionTrue,
}, {
Type: TriggerConditionSubscriberResolved,
Status: corev1.ConditionUnknown,
}, {
Type: TriggerConditionSubscribed,
Status: corev1.ConditionTrue,
},
},
},
Expand Down