-
Notifications
You must be signed in to change notification settings - Fork 630
Use WaitForPodRunning instead of WaitForResourceReady on pods #4073
Copy link
Copy link
Closed
Labels
area/test-and-releaseTest infrastructure, tests or releaseTest infrastructure, tests or releasegood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.priority/critical-urgentHighest priority. Must be actively worked on as someone's top priority right now.Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
Metadata
Metadata
Assignees
Labels
area/test-and-releaseTest infrastructure, tests or releaseTest infrastructure, tests or releasegood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.priority/critical-urgentHighest priority. Must be actively worked on as someone's top priority right now.Highest priority. Must be actively worked on as someone's top priority right now.
Problem
Since conformance tests cannot be run for non-channel based brokers, we copy-pasted them in https://github.com/knative-sandbox/eventing-kafka-broker, and we started to observe flaky tests.
After digging we found out that the use of
WaitForResourceReadyon pods makes our tests flaky, see knative-extensions/eventing-kafka-broker#183, discussion, and diff.We should check all of our tests and use WaitForPodRunning instead of WaitForResourceReady when we're waiting for pods to be running.
Additional Info
/area test-and-release
/good-first-issue