Skip to content

Project pod name as env var in our deployments#4072

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
pierDipi:inject-pod-name
Sep 18, 2020
Merged

Project pod name as env var in our deployments#4072
knative-prow-robot merged 1 commit into
knative:masterfrom
pierDipi:inject-pod-name

Conversation

@pierDipi
Copy link
Copy Markdown
Member

Proposed Changes

  • Project pod name as env var in our deployments

- knative/pkg#1714

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 18, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestBrokerV1Beta1DataPlaneConsumer/MTChannelBasedBroker-eventing.knative.dev/v1beta1/Events_are_filtered
test/conformance.TestBrokerV1Beta1DataPlaneConsumer/MTChannelBasedBroker-eventing.knative.dev/v1beta1
test/conformance.TestBrokerV1Beta1DataPlaneConsumer

@aliok
Copy link
Copy Markdown
Member

aliok commented Sep 18, 2020

/retest

@pierDipi
Copy link
Copy Markdown
Member Author

    operation.go:73: Object that did not become ready {pod v1}-first-filtered-event-sender when dumping error state: &{TypeMeta:{Kind:Pod APIVersion:v1} ObjectMeta:{Name:first-filtered-event-sender GenerateName: Namespace:test-broker-v1-beta1-data-plane-consumer-pb42g SelfLink:/api/v1/namespaces/test-broker-v1-beta1-data-plane-consumer-pb42g/pods/first-filtered-event-sender UID:3bc9420d-df90-40a5-81e3-a51c4050553c ResourceVersion:12487 Generation:0 CreationTimestamp:2020-09-18 08:35:05 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]} Status:{ObservedGeneration:0 Conditions:[{Type:Initialized Status:True Severity: LastTransitionTime:{Inner:2020-09-18 08:35:05 +0000 UTC} Reason:PodCompleted Message:} {Type:Ready Status:False Severity: LastTransitionTime:{Inner:2020-09-18 08:35:17 +0000 UTC} Reason:PodCompleted Message:} {Type:ContainersReady Status:False Severity: LastTransitionTime:{Inner:2020-09-18 08:35:17 +0000 UTC} Reason:PodCompleted Message:} {Type:PodScheduled Status:True Severity: LastTransitionTime:{Inner:2020-09-18 08:35:05 +0000 UTC} Reason: Message:}] Annotations:map[]}}
    operation.go:75: Failed to get {pod v1}-first-filtered-event-sender ready: <nil>

I know how to fix this! 🎉
/retest

Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Can we have the same for the things in eventing-contrib?

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@pierDipi
Copy link
Copy Markdown
Member Author

I think there is a code freeze in eventing-contrib or people are moving code to sandbox, to keep track of this I would open an issue in each sandbox repository, WDYT?

@aliok
Copy link
Copy Markdown
Member

aliok commented Sep 18, 2020

I think there is a code freeze in eventing-contrib or people are moving code to sandbox, to keep track of this I would open an issue in each sandbox repository, WDYT?

I think that would be the approach. Let me create some tickets.

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@knative-prow-robot knative-prow-robot merged commit 5508e48 into knative:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants