-
Notifications
You must be signed in to change notification settings - Fork 630
Remove use of finalizer in PingSource adapter #4986
Copy link
Copy link
Closed
Labels
area/sourceskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/good-first-issueDenotes an issue ready for a new contributor.Denotes an issue ready for a new contributor.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
Metadata
Metadata
Assignees
Labels
area/sourceskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/good-first-issueDenotes an issue ready for a new contributor.Denotes an issue ready for a new contributor.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Problem
The use of finalizers in the PingSource adapter is overkill since updating the internal state cannot fail.
Similar to #4509
Persona:
Which persona is this feature for?
Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.
Time Estimate (optional):
How many developer-days do you think this may take to resolve?
<1
Additional context (optional)
Add any other context about the feature request here.