Skip to content

add post 022 job to remove pingsource finalizer#5008

Merged
knative-prow-robot merged 4 commits into
knative:mainfrom
zhaojizhuang:post-install
Mar 31, 2021
Merged

add post 022 job to remove pingsource finalizer#5008
knative-prow-robot merged 4 commits into
knative:mainfrom
zhaojizhuang:post-install

Conversation

@zhaojizhuang
Copy link
Copy Markdown
Contributor

@zhaojizhuang zhaojizhuang commented Mar 3, 2021 •
edited
Loading

Fixes #4986

Proposed Changes

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 3, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2021
@zhaojizhuang
Copy link
Copy Markdown
Contributor Author

zhaojizhuang commented Mar 3, 2021

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2021
@zhaojizhuang zhaojizhuang mentioned this pull request Mar 3, 2021
Merged
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

Merging #5008 (c885403) into main (3ebce0d) will increase coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5008      +/-   ##
==========================================
+ Coverage   83.41%   83.98%   +0.56%     
==========================================
  Files         283      283              
  Lines        7955     7966      +11     
==========================================
+ Hits         6636     6690      +54     
+ Misses        947      901      -46     
- Partials      372      375       +3
Impacted Files Coverage Δ
pkg/adapter/v2/main.go 60.86% <0.00%> (+2.73%) ⬆️
pkg/kncloudevents/utils.go 69.23% <0.00%> (+69.23%) ⬆️
pkg/kncloudevents/message_receiver.go 90.69% <0.00%> (+90.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebce0d...c885403. Read the comment docs.

vaikas
vaikas reviewed Mar 3, 2021
View reviewed changes
Comment thread cmd/v0.22/pingsource-cleanup/README.md
Comment thread cmd/v0.22/pingsource-cleanup/README.md Outdated
@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 4, 2021

Don't we need some YAML on the config folder to get the post job released ?

FYI @maschmid and @lionelvillard

Base automatically changed from master to main March 8, 2021 17:40
@zhaojizhuang
Copy link
Copy Markdown
Contributor Author

zhaojizhuang commented Mar 26, 2021

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2021
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Mar 26, 2021
@zhaojizhuang
Copy link
Copy Markdown
Contributor Author

zhaojizhuang commented Mar 26, 2021

Don't we need some YAML on the config folder to get the post job released ?

FYI @maschmid and @lionelvillard

@matzew I have move it to config dir

@zhaojizhuang
Copy link
Copy Markdown
Contributor Author

zhaojizhuang commented Mar 26, 2021

/assign @lionelvillard

@zhaojizhuang zhaojizhuang force-pushed the post-install branch 2 times, most recently from 4f424c5 to 4159937 Compare March 27, 2021 05:19
lionelvillard
lionelvillard reviewed Mar 29, 2021
View reviewed changes
Comment thread cmd/v0.22/pingsource-cleanup/README.md Outdated
lionelvillard
lionelvillard reviewed Mar 29, 2021
View reviewed changes
Comment thread hack/generate-yamls.sh Outdated
lionelvillard
lionelvillard reviewed Mar 29, 2021
View reviewed changes
Comment thread config/post-install/v0.22.0/clusterrole.yaml Outdated
@zhaojizhuang
Copy link
Copy Markdown
Contributor Author

zhaojizhuang commented Mar 29, 2021

@lionelvillard done! Thank you so much

lionelvillard
lionelvillard reviewed Mar 31, 2021
View reviewed changes
Comment thread cmd/v0.22/pingsource-cleanup/main.go Outdated
lionelvillard
lionelvillard reviewed Mar 31, 2021
View reviewed changes
Comment thread cmd/v0.22/pingsource-cleanup/README.md Outdated
lionelvillard
lionelvillard reviewed Mar 31, 2021
View reviewed changes
Comment thread cmd/v0.22/pingsource-cleanup/main.go Outdated
lionelvillard
lionelvillard reviewed Mar 31, 2021
View reviewed changes
Comment thread cmd/v0.22/pingsource-cleanup/main.go Outdated
lionelvillard
lionelvillard reviewed Mar 31, 2021
View reviewed changes
Comment thread cmd/v0.22/pingsource-cleanup/main.go
@lionelvillard lionelvillard mentioned this pull request Mar 31, 2021
Merged
@lionelvillard
Copy link
Copy Markdown
Contributor

lionelvillard commented Mar 31, 2021

Great looks good! Thanks.

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@knative-prow-robot knative-prow-robot merged commit 6c632d1 into knative:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lionelvillard lionelvillard lionelvillard left review comments

@vaikas vaikas vaikas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lionelvillard lionelvillard

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove use of finalizer in PingSource adapter

5 participants

@zhaojizhuang @matzew @lionelvillard @knative-prow-robot @vaikas