Skip to content

DeliverySpec.Timeout not available on Trigger #5654

@JackSilk

Description

@JackSilk

Describe the bug
After setting the experimental feature to be enabled, Kubernetes still rejects Triggers that have a value for the DeliverySpec.Timeout field

Error is like follows:
error: error validating "./eventing/templates/triggers/failure-trigger.yaml": error validating data: ValidationError(Trigger.spec.delivery): unknown field "timeout" in dev.knative.eventing.v1.Trigger.spec.delivery; if you choose to ignore these errors, turn validation off with --validate=false

Expected behavior
Trigger is created
To Reproduce
Create a trigger with the delivery.timeout field set to a valid value

Knative release version
0.24.0
Additional context
Using the timeout field with e.g Broker works fine - I suspect the problem is the trigger Delivery spec is missing
x-kubernetes-preserve-unknown-fields: true # This is necessary to enable the experimental feature delivery-timeout

Metadata

Metadata

Assignees

Labels

area/brokerskind/bugCategorizes issue or PR as related to a bug.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions