Skip to content

DeliverySpec.Timeout on Broker and Trigger#5687

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
pierDipi:KNATIVE-5654_DeliverySpec.Timeout
Sep 1, 2021
Merged

DeliverySpec.Timeout on Broker and Trigger#5687
knative-prow-robot merged 1 commit into
knative:mainfrom
pierDipi:KNATIVE-5654_DeliverySpec.Timeout

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Aug 31, 2021

Fixes #5654

Proposed Changes

  • Preserve unknown fields on trigger.spec.delivery
  • Add test for broker and trigger using spec.delivery.timeout

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Trigger accepts a timeout field in its delivery parameters `spec.delivery.timeout`

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 31, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 31, 2021
@pierDipi
Copy link
Copy Markdown
Member Author

/test all

@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2021
@pierDipi pierDipi force-pushed the KNATIVE-5654_DeliverySpec.Timeout branch from c725a1b to bd8b0d4 Compare August 31, 2021 19:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 31, 2021

Codecov Report

Merging #5687 (0a00df5) into main (00ab8a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5687   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         200      200           
  Lines        6261     6261           
=======================================
  Hits         5177     5177           
  Misses        750      750           
  Partials      334      334           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ab8a1...0a00df5. Read the comment docs.

@pierDipi pierDipi marked this pull request as ready for review August 31, 2021 19:55
@pierDipi
Copy link
Copy Markdown
Member Author

/cherry-pick release-0.25

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-0.25 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Copy Markdown
Member Author

/cherry-pick release-0.24

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-0.24 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi pierDipi force-pushed the KNATIVE-5654_DeliverySpec.Timeout branch 2 times, most recently from 13ea174 to 1500d48 Compare August 31, 2021 20:27
@pierDipi pierDipi changed the title [WIP] DeliverySpec.Timeout on Broker and Trigger DeliverySpec.Timeout on Broker and Trigger Aug 31, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2021
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi force-pushed the KNATIVE-5654_DeliverySpec.Timeout branch from 1500d48 to 0a00df5 Compare August 31, 2021 20:47
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@pierDipi: new pull request created: #5689

Details

In response to this:

/cherry-pick release-0.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@pierDipi: new pull request created: #5690

Details

In response to this:

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi pierDipi deleted the KNATIVE-5654_DeliverySpec.Timeout branch September 1, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeliverySpec.Timeout not available on Trigger

3 participants