Skip to content

[release-0.25] DeliverySpec.Timeout on Broker and Trigger#5689

Merged
knative-prow-robot merged 1 commit into
knative:release-0.25from
knative-prow-robot:cherry-pick-5687-to-release-0.25
Sep 2, 2021
Merged

[release-0.25] DeliverySpec.Timeout on Broker and Trigger#5689
knative-prow-robot merged 1 commit into
knative:release-0.25from
knative-prow-robot:cherry-pick-5687-to-release-0.25

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot commented Sep 1, 2021

This is an automated cherry-pick of #5687

Trigger accepts a timeout field in its delivery parameters `spec.delivery.timeout`

@pierDipi @knative-prow-robot
DeliverySpec.Timeout on Broker and Trigger
f713c0c 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 1, 2021
@knative-prow-robot knative-prow-robot mentioned this pull request Sep 1, 2021
Merged
5 tasks
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Sep 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Sep 1, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Sep 1, 2021
@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Sep 1, 2021

@googlebot I consent.

@google-cla google-cla Bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Sep 1, 2021
@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Sep 1, 2021

/approve

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 1, 2021 •
edited
Loading

Codecov Report

Merging #5689 (f713c0c) into release-0.25 (0c41e6d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-0.25    #5689   +/-   ##
=============================================
  Coverage         82.77%   82.77%           
=============================================
  Files               200      200           
  Lines              6258     6258           
=============================================
  Hits               5180     5180           
  Misses              748      748           
  Partials            330      330

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c41e6d...f713c0c. Read the comment docs.

matzew
matzew approved these changes Sep 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor Author

knative-prow-robot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 5d98ec5 into knative:release-0.25 Sep 2, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Sep 28, 2021
@knative-prow-robot @pierDipi @matzew
DeliverySpec.Timeout on Broker and Trigger (knative#5689)
c82272a 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Sep 29, 2021
@matzew @knative-prow-robot @pierDipi
DeliverySpec.Timeout on Broker and Trigger (knative#5689) (#1426)
926927f 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi mentioned this pull request Nov 15, 2021
Merged
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Nov 15, 2021
@pierDipi @knative-prow-robot
@knative-automation @travis-minke-sap
[release-0.25] Sync upstream bug fixes (#1478)
c11e169 
* DeliverySpec.Timeout on Broker and Trigger (knative#5689)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* upgrade to latest dependencies (knative#5699)

bumping knative.dev/pkg 21eb4c1...844a6bc:
  > 844a6bc [release-0.25] allow unknown metadata fields (# 2254)
  > 5bed044 Drop redundant pointers and decoders (# 2259)

Signed-off-by: Knative Automation <automation@knative.team>

* Validate DeliverySpec in Channels & Subscriptions (knative#5779)

Co-authored-by: I867318 <travis.minke@sap.com>

* Default dead letter sink namespace to the object namespace

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* Add unit test

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Run hack/update-codegen.sh

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: I867318 <travis.minke@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

Assignees

@matzew matzew

@pierDipi pierDipi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knative-prow-robot @pierDipi @matzew