This repository was archived by the owner on Nov 28, 2022. It is now read-only.
[release-v0.25] Backport: DeliverySpec.Timeout on Broker and Trigger (#5689)#1426
Merged
openshift-merge-robot merged 1 commit intoSep 29, 2021
Merged
Conversation
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
openshift-ci
Bot
added
area/test-and-release
Member
Author
|
/retest
On Tue 28. Sep 2021 at 21:11, openshift-ci[bot] ***@***.***> wrote:
@matzew <https://github.com/matzew>: The following test *failed*, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/49-reconciler-aws-ocp-49 c82272a
<c82272a>
link
<https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_knative-eventing/1426/pull-ci-openshift-knative-eventing-release-v0.25-49-reconciler-aws-ocp-49/1442867751923224576>
true /test 49-reconciler-aws-ocp-49
Full PR test history
<https://prow.ci.openshift.org/pr-history?org=openshift&repo=knative-eventing&pr=1426>.
Your PR dashboard
<https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:matzew>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1426 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTQWHR5SASUVIFXSLPDUEIHORANCNFSM5E5UZLWA>
.
--
Sent from Gmail Mobile
|
matzew
changed the title
matzew
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devguyio, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pierangelo Di Pilato pierangelodipilato@gmail.com
Co-authored-by: Pierangelo Di Pilato pierangelodipilato@gmail.com
@devguyio I'd like to port this change from @pierDipi to here.
Once that is merged, I'd like to bump tthis to 0.25.1
https://github.com/openshift-knative/serverless-operator/blob/main/olm-catalog/serverless-operator/project.yaml#L29
and change the image promotion on
openshift/releasefor the 0.25.0 CI job to be also 0.25.1