Skip to content

[release-0.25] Validate DeliverySpec in Channels & Subscriptions#5779

Merged
knative-prow-robot merged 1 commit into
knative:release-0.25from
knative-prow-robot:cherry-pick-5777-to-release-0.25
Oct 4, 2021
Merged

[release-0.25] Validate DeliverySpec in Channels & Subscriptions#5779
knative-prow-robot merged 1 commit into
knative:release-0.25from
knative-prow-robot:cherry-pick-5777-to-release-0.25

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #5777

Channel and Subscription will now enforce validation of the "delivery" field.

@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 4, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Oct 4, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Oct 4, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 4, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-0.25@0df5afe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.25    #5779   +/-   ##
===============================================
  Coverage                ?   82.79%           
===============================================
  Files                   ?      200           
  Lines                   ?     6264           
  Branches                ?        0           
===============================================
  Hits                    ?     5186           
  Misses                  ?      748           
  Partials                ?      330           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df5afe...974b2dc. Read the comment docs.

Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/assign @travis-minke-sap

for CLA consent

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@travis-minke-sap
Copy link
Copy Markdown
Contributor

@googlebot I consent

@google-cla google-cla Bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Oct 4, 2021
@knative-prow-robot knative-prow-robot merged commit 4b3c52f into knative:release-0.25 Oct 4, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 4, 2021
Co-authored-by: I867318 <travis.minke@sap.com>
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Oct 5, 2021
Co-authored-by: I867318 <travis.minke@sap.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: I867318 <travis.minke@sap.com>
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Nov 15, 2021
* DeliverySpec.Timeout on Broker and Trigger (knative#5689)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* upgrade to latest dependencies (knative#5699)

bumping knative.dev/pkg 21eb4c1...844a6bc:
  > 844a6bc [release-0.25] allow unknown metadata fields (# 2254)
  > 5bed044 Drop redundant pointers and decoders (# 2259)

Signed-off-by: Knative Automation <automation@knative.team>

* Validate DeliverySpec in Channels & Subscriptions (knative#5779)

Co-authored-by: I867318 <travis.minke@sap.com>

* Default dead letter sink namespace to the object namespace

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* Add unit test

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Run hack/update-codegen.sh

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: I867318 <travis.minke@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants