This repository was archived by the owner on Nov 28, 2022. It is now read-only.
[release-v0.25] Backport: Validate DeliverySpec in Channels & Subscriptions (#5779)#1439
Merged
openshift-merge-robot merged 1 commit intoOct 5, 2021
Conversation
Co-authored-by: I867318 <travis.minke@sap.com>
openshift-ci
Bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest
On Mon 4. Oct 2021 at 21:26, openshift-ci[bot] ***@***.***> wrote:
@matzew <https://github.com/matzew>: The following test *failed*, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/49-reconciler-aws-ocp-49 ed66d9c
<ed66d9c>
link
<https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_knative-eventing/1439/pull-ci-openshift-knative-eventing-release-v0.25-49-reconciler-aws-ocp-49/1445045717742653440>
true /test 49-reconciler-aws-ocp-49
Full PR test history
<https://prow.ci.openshift.org/pr-history?org=openshift&repo=knative-eventing&pr=1439>.
Your PR dashboard
<https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:matzew>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1439 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTQQVJOIIQE7MIGAQI3UFH5WFANCNFSM5FJT5X6A>
.
--
Sent from Gmail Mobile
|
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Member
Author
|
/retest
On Tue 5. Oct 2021 at 05:44, openshift-ci[bot] ***@***.***> wrote:
@matzew <https://github.com/matzew>: The following test *failed*, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/49-reconciler-aws-ocp-49 ed66d9c
<ed66d9c>
link
<https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_knative-eventing/1439/pull-ci-openshift-knative-eventing-release-v0.25-49-reconciler-aws-ocp-49/1445170793561460736>
true /test 49-reconciler-aws-ocp-49
Full PR test history
<https://prow.ci.openshift.org/pr-history?org=openshift&repo=knative-eventing&pr=1439>.
Your PR dashboard
<https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:matzew>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1439 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTXA3A4BTHRASYPUYCLUFJYCDANCNFSM5FJT5X6A>
.
--
Sent from Gmail Mobile
|
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: I867318 travis.minke@sap.com