[release-0.24] DeliverySpec.Timeout on Broker and Trigger#5690
Conversation
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
/approve |
Codecov Report
@@ Coverage Diff @@
## release-0.24 #5690 +/- ##
===============================================
Coverage ? 82.65%
===============================================
Files ? 198
Lines ? 6162
Branches ? 0
===============================================
Hits ? 5093
Misses ? 742
Partials ? 327 Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
* [release-0.24] [PingSource] disable @every (knative#5590) * disable @every * simpler validation Co-authored-by: Lionel Villard <villard@us.ibm.com> * DeliverySpec.Timeout on Broker and Trigger (knative#5690) Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Lionel Villard <villard@us.ibm.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
* [release-0.24] [PingSource] disable @every (knative#5590) * disable @every * simpler validation Co-authored-by: Lionel Villard <villard@us.ibm.com> * DeliverySpec.Timeout on Broker and Trigger (knative#5690) Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Lionel Villard <villard@us.ibm.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
This is an automated cherry-pick of #5687