Skip to content

[release-0.24] [PingSource] disable @every#5590

Merged
knative-prow-robot merged 2 commits into
knative:release-0.24from
knative-prow-robot:cherry-pick-5585-to-release-0.24
Jul 13, 2021
Merged

[release-0.24] [PingSource] disable @every#5590
knative-prow-robot merged 2 commits into
knative:release-0.24from
knative-prow-robot:cherry-pick-5585-to-release-0.24

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #5585

:bug: PingSource schedules starting with `@every` are now properly rejected.

@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 13, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jul 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 13, 2021
@lionelvillard
Copy link
Copy Markdown
Contributor

@googlebot I consent

@google-cla google-cla Bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jul 13, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 13, 2021

Codecov Report

Merging #5590 (04512e0) into release-0.24 (a574b7b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-0.24    #5590      +/-   ##
================================================
+ Coverage         82.62%   82.65%   +0.02%     
================================================
  Files               198      198              
  Lines              6154     6162       +8     
================================================
+ Hits               5085     5093       +8     
  Misses              742      742              
  Partials            327      327              
Impacted Files Coverage Δ
pkg/apis/sources/v1/ping_validation.go 100.00% <100.00%> (ø)
pkg/apis/sources/v1beta2/ping_validation.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a574b7b...04512e0. Read the comment docs.

@lionelvillard
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@knative-prow-robot knative-prow-robot merged commit b4cabbf into knative:release-0.24 Jul 13, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Sep 2, 2021
* disable @every

* simpler validation

Co-authored-by: Lionel Villard <villard@us.ibm.com>
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Sep 3, 2021
* [release-0.24] [PingSource] disable @every (knative#5590)

* disable @every

* simpler validation

Co-authored-by: Lionel Villard <villard@us.ibm.com>

* DeliverySpec.Timeout on Broker and Trigger (knative#5690)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Lionel Villard <villard@us.ibm.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
mgencur pushed a commit to mgencur/eventing that referenced this pull request Sep 6, 2021
* [release-0.24] [PingSource] disable @every (knative#5590)

* disable @every

* simpler validation

Co-authored-by: Lionel Villard <villard@us.ibm.com>

* DeliverySpec.Timeout on Broker and Trigger (knative#5690)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Lionel Villard <villard@us.ibm.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants