Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

[0.24] backports from upstream#1390

Merged
openshift-merge-robot merged 2 commits into
openshift:release-v0.24from
matzew:0.24_backports_from_upstream
Sep 3, 2021
Merged

[0.24] backports from upstream#1390
openshift-merge-robot merged 2 commits into
openshift:release-v0.24from
matzew:0.24_backports_from_upstream

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Sep 2, 2021

Adding some backports from upstream

/assign @lberk
/assign @devguyio

knative-prow-robot and others added 2 commits September 2, 2021 16:46
* disable @every

* simpler validation

Co-authored-by: Lionel Villard <villard@us.ibm.com>
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@openshift-ci openshift-ci Bot added the area/test-and-release Issues or PRs related to test and release label Sep 2, 2021
@openshift-ci openshift-ci Bot requested review from alanfx and devguyio September 2, 2021 14:50
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Sep 2, 2021 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Sep 3, 2021

/test 48-reconciler-aws-ocp-48

1 similar comment
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Sep 3, 2021

/test 48-reconciler-aws-ocp-48

Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 03160c8 into openshift:release-v0.24 Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants