[PingSource] disable @every

[lionelvillard]

Fixes #5584

Proposed Changes

• 🐛 reject non-standard @every schedule.

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

:bug: PingSource schedules starting with `@every` are now properly rejected.

Docs

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #5585 (8895de5) into main (8678c3c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5585      +/-   ##
==========================================
+ Coverage   82.66%   82.68%   +0.02%     
==========================================
  Files         198      198              
  Lines        6172     6180       +8     
==========================================
+ Hits         5102     5110       +8     
  Misses        743      743              
  Partials      327      327              

Impacted Files	Coverage Δ
pkg/apis/sources/v1/ping_validation.go	100.00% <100.00%> (ø)
pkg/apis/sources/v1beta2/ping_validation.go	100.00% <100.00%> (ø)
pkg/channel/stats_reporter.go	86.66% <0.00%> (ø)
pkg/broker/filter/stats_reporter.go	87.30% <0.00%> (ø)
pkg/broker/ingress/stats_reporter.go	87.75% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8678c3c...8895de5. Read the comment docs.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/sources/v1/ping_validation.go	100.0%	95.5%	-4.5
pkg/apis/sources/v1beta2/ping_validation.go	100.0%	95.5%	-4.5

[cr22rc]

/lgtm

[lionelvillard]

/test pull-knative-eventing-upgrade-tests

[lionelvillard]

/hold

I will simplify the logic

[lionelvillard]

/unhold

[cr22rc]

/lgtm

[lionelvillard]

/cherry-pick release-0.24
/cherry-pick release-0.23

[knative-prow-robot]

@lionelvillard: new pull request created: #5590

Details

In response to this:

/cherry-pick release-0.24
/cherry-pick release-0.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lionelvillard]

/cherry-pick release-0.23

[knative-prow-robot]

@lionelvillard: new pull request created: #5591

Details

In response to this:

/cherry-pick release-0.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.