Skip to content

Format markdown#1390

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
mattmoor-sockpuppet:prettier-knative-eventing8s7qj-pod-221664
Jun 13, 2019
Merged

Format markdown#1390
knative-prow-robot merged 1 commit into
knative:masterfrom
mattmoor-sockpuppet:prettier-knative-eventing8s7qj-pod-221664

Conversation

@mattmoor-sockpuppet
Copy link
Copy Markdown
Contributor

@mattmoor-sockpuppet mattmoor-sockpuppet commented Jun 12, 2019

Produced via: prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)

@mattmoor-sockpuppet
Format markdown
5e0a8f5 
Produced via: `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 12, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 12, 2019

Hi @mattmoor-sockpuppet. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mattmoor
mattmoor reviewed Jun 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/assign @n3wscott

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2019
@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Jun 13, 2019

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor-sockpuppet, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2019
@knative-prow-robot knative-prow-robot merged commit 30c1f5b into knative:master Jun 13, 2019
mgencur pushed a commit to mgencur/eventing that referenced this pull request Sep 6, 2021
@matzew @knative-prow-robot
@lionelvillard @pierDipi
[0.24] backports from upstream (knative#1390)
03160c8 
* [release-0.24] [PingSource] disable @every (knative#5590)

* disable @every

* simpler validation

Co-authored-by: Lionel Villard <villard@us.ibm.com>

* DeliverySpec.Timeout on Broker and Trigger (knative#5690)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Lionel Villard <villard@us.ibm.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
mgencur pushed a commit to mgencur/eventing that referenced this pull request Sep 6, 2021
@matzew @knative-prow-robot
@lionelvillard @pierDipi @mgencur
[0.24] backports from upstream (knative#1390)
b2572d7 
* [release-0.24] [PingSource] disable @every (knative#5590)

* disable @every

* simpler validation

Co-authored-by: Lionel Villard <villard@us.ibm.com>

* DeliverySpec.Timeout on Broker and Trigger (knative#5690)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Lionel Villard <villard@us.ibm.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Cali0707 pushed a commit to Cali0707/eventing that referenced this pull request Jul 29, 2025
@red-hat-konflux-kflux-prd-rh02
[release-v1.17] Update Konflux references (knative#1390)
c67adb4 
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux-kflux-prd-rh02[bot] <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbrowning bbrowning Awaiting requested review from bbrowning

@matzew matzew Awaiting requested review from matzew

1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mattmoor-sockpuppet @knative-prow-robot @n3wscott @mattmoor @googlebot